From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 10/11] VMX: work around lacking VNMI support Date: Tue, 23 Sep 2008 12:26:55 +0300 Message-ID: <20080923092655.GD3072@minantech.com> References: <48D74CE6.5060008@siemens.com> <200809231708.09617.sheng.yang@intel.com> <20080923091509.GC3072@minantech.com> <200809231724.50988.sheng.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kiszka , kvm-devel , Avi Kivity To: "Yang, Sheng" Return-path: Received: from il.qumranet.com ([212.179.150.194]:38648 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751178AbYIWJ05 (ORCPT ); Tue, 23 Sep 2008 05:26:57 -0400 Content-Disposition: inline In-Reply-To: <200809231724.50988.sheng.yang@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Sep 23, 2008 at 05:24:50PM +0800, Yang, Sheng wrote: > On Tuesday 23 September 2008 17:15:09 Gleb Natapov wrote: > > On Tue, Sep 23, 2008 at 05:08:09PM +0800, Yang, Sheng wrote: > > > > > >>> We still get here with vmx->soft_vnmi_blocked = 1. Trying to find > > > > > >>> out how. > > > > > >> > > > > > >> We should only come along here with vnmi blocked on reinjection > > > > > >> (after a fault on calling the handler). > > > > > > > > > > > > I see that nmi_injected is never cleared and it is check before > > > > > > calling vmx_inject_nmi(); > > > > > > > > > > That should happen in vmx_complete_interrupts, but only if the exit > > > > > takes place after the NMI has been successfully delivered to the > > > > > guest (which is not the case if invoking the handler raises an > > > > > exception). So far for the theory... > > > > > > > > Okey, I have this one in dmesg: > > > > kvm_handle_exit: unexpected, valid vectoring info and exit reason is > > > > 0x9 > > > > > > Oh... Another task switch issue... > > > > > > I think it's may not be a issue import by this patchset? Seems need more > > > debug... > > > > > > The patchset is OK for me, except I don't know when we would need that > > > timeout one (buggy guest?...), and we may also root cause this issue or > > > ensure that it's not a regression. > > > > Without the patch series kvm doesn't inject NMIs on this machine, so guest > > hangs. It's hard to tell if this message is caused by these patches or not. > > > Maybe try to reproduce it on virtual_nmi support machine is OK. But I only got > Windows 2003 server edition by the hand. Does other Windows behaviour the > same? > That is exactly what I am using. Run it with SMP hal and do hibernate. -- Gleb.