Re: [PATCH 0/4] Allow enabling kvm_trace on external module

[Eduardo Habkost <ehabkost@redhat.com>]

On Wed, Sep 24, 2008 at 04:48:35PM +0300, Avi Kivity wrote:
> Eduardo Habkost wrote:
>> This series adds compat code to allow enabling kvm_trace when building
>> KVM as an external module on older kernels.
>>
>> The most hackish part is the last patch, that adds --with-kvm-trace to
>> configure and adds an include to a generated file on kernel/x86/Kbuild. It
>> doesn't look pretty, so suggestions on how to make this better are
>> welcome.
>>   
>
> Applied all, thanks.  We could improve Kbuild by having kernel/Makefile  
> include config.mak and pass some variable to Kbuild somehow, but diving  
> into Kbuild isn't my idea of a week well spent.

Oops. I've just noticed I broke './configure --with-patched-kernel'. Fix below.

---
From: Eduardo Habkost <ehabkost@redhat.com>
Date: Wed, 24 Sep 2008 14:11:42 -0300
Subject: Always generate config.kbuild

When implementing --with-kvm-trace, I supposed make would never enter
the 'kernel' directory when compiling with --with-patched-kernel. I was
wrong and broke --with-patched-kernel.

Change configure to always generate config.kbuild on the kernel
directory. Otherwise make will explode on 'make header-sync', that runs
even when --with-patched-kernel was used.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 configure |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 78c2f9c..3b27364 100755
--- a/configure
+++ b/configure
@@ -137,8 +137,6 @@ LD=$cross_prefix$ld
 OBJCOPY=$cross_prefix$objcopy
 EOF
 
-if [ -n "$want_module" ];then
 cat <<EOF > kernel/config.kbuild
 CONFIG_KVM_TRACE=$kvm_trace
 EOF
-fi
-- 
1.5.5.GIT


-- 
Eduardo