From: "Yang, Sheng" <sheng.yang@intel.com>
To: Avi Kivity <avi@redhat.com>
Cc: "Han, Weidong" <weidong.han@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Amit Shah <amit.shah@redhat.com>,
"benami@il.ibm.com" <benami@il.ibm.com>,
"muli@il.ibm.com" <muli@il.ibm.com>,
"Kay, Allen M" <allen.m.kay@intel.com>,
"Zhang, Xiantao" <xiantao.zhang@intel.com>
Subject: Re: Remaining passthrough/VT-d tasks list
Date: Wed, 24 Sep 2008 17:43:01 +0800 [thread overview]
Message-ID: <200809241743.02566.sheng.yang@intel.com> (raw)
In-Reply-To: <48DA06ED.9090605@redhat.com>
On Wednesday 24 September 2008 17:22:53 Avi Kivity wrote:
> Yang, Sheng wrote:
> >> We only have three pci interrupts at this point (though this could be
> >> easily extended); if you start the guest with a non-trivial number of
> >> devices, you will have shared guest interrupts.
> >>
> >> (of course, when I pointed this out during review, people said it could
> >> be done later, then forgot all about it)
> >
> > .....
> >
> > I think it's a performance issue, not break it? How about do it like Xen
> > side? Try best to avoid the share, extended the pci interrupts, improve
> > hash algorithm. Is there anything else we can do?
>
> Two separate issues:
>
> 1. only three guest pci interrupts
>
> That's a performance issue, not correctness. can be fixed by using gsi
> 16-23 in APIC mode, and by adding another IOAPIC (so we can use gsi
> 16-47). Anthony Xu posted some patches for this, not sure where this
> stands, but it was the right approach.
>
> 2. shared guest pci interrupts
>
> That's a correctness issue. No matter how many interrupts we have, we
> may have sharing issues. Of course with only three the issue is very
> pressing since we will get sharing with just a few devices. Currently
> if two assigned devices share a guest interrupts, or if an emulated
> device shares an interrupt with an assigned device, things will break.
>
> They need to be fixed independently.
About the second issue, I don't understand how it would break... Would you
please give more details on this? It's a QEmu bug or IOAPIC bug?
--
regards
Yang, Sheng
next prev parent reply other threads:[~2008-09-24 9:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 6:15 Remaining passthrough/VT-d tasks list Han, Weidong
2008-09-24 6:31 ` Yang, Sheng
2008-09-24 6:58 ` Zhang, Xiantao
2008-09-24 7:41 ` Amit Shah
2008-09-24 7:51 ` Han, Weidong
2008-09-24 8:02 ` Amit Shah
2008-09-24 8:38 ` Han, Weidong
2008-09-24 8:49 ` Avi Kivity
2008-09-24 9:56 ` Amit Shah
2008-09-24 12:25 ` Han, Weidong
2008-09-24 8:46 ` Avi Kivity
2008-09-24 9:58 ` Amit Shah
2008-09-24 10:46 ` Avi Kivity
2008-09-24 14:46 ` Han, Weidong
2008-09-24 8:38 ` Avi Kivity
2008-09-24 8:46 ` Yang, Sheng
2008-09-27 9:15 ` Yang, Sheng
2008-09-27 9:49 ` Avi Kivity
2008-09-27 10:09 ` Jan Kiszka
2008-09-27 10:16 ` Avi Kivity
2008-09-28 6:03 ` Muli Ben-Yehuda
2008-09-28 1:48 ` Tian, Kevin
2008-09-28 2:03 ` Dong, Eddie
2008-09-28 2:29 ` Tian, Kevin
2008-09-28 4:22 ` Avi Kivity
2008-09-28 4:50 ` Tian, Kevin
2008-09-28 5:04 ` Avi Kivity
2008-09-28 5:17 ` Yang, Sheng
2008-10-05 10:18 ` Avi Kivity
2008-09-28 5:54 ` Yang, Sheng
2008-09-24 8:34 ` Avi Kivity
2008-09-24 8:42 ` Yang, Sheng
2008-09-24 8:53 ` Avi Kivity
2008-09-24 9:08 ` Yang, Sheng
2008-09-24 9:22 ` Avi Kivity
2008-09-24 9:43 ` Yang, Sheng [this message]
2008-09-24 9:51 ` Avi Kivity
2008-09-28 6:09 ` Yang, Sheng
2008-09-24 9:40 ` Amit Shah
2008-09-24 9:46 ` Avi Kivity
2008-09-24 15:39 ` Dong, Eddie
2008-09-27 10:11 ` Avi Kivity
2008-09-28 2:28 ` Dong, Eddie
2008-09-28 4:25 ` Avi Kivity
2008-09-28 5:54 ` Dong, Eddie
2008-09-24 8:39 ` Avi Kivity
2008-09-24 8:50 ` Han, Weidong
2008-09-24 9:12 ` Avi Kivity
2008-09-24 15:12 ` Anthony Liguori
2008-09-24 15:38 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809241743.02566.sheng.yang@intel.com \
--to=sheng.yang@intel.com \
--cc=allen.m.kay@intel.com \
--cc=amit.shah@redhat.com \
--cc=avi@redhat.com \
--cc=benami@il.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=muli@il.ibm.com \
--cc=weidong.han@intel.com \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).