From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amit Shah Subject: Re: [PATCH] KVM: Unregister IRQ ACK notifier with in-kernel irqchip Date: Wed, 8 Oct 2008 12:38:52 +0530 Message-ID: <200810081238.52574.amit.shah@redhat.com> References: <1223447960-30355-1-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Avi Kivity , kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:59183 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752218AbYJHHKN (ORCPT ); Wed, 8 Oct 2008 03:10:13 -0400 In-Reply-To: <1223447960-30355-1-git-send-email-sheng@linux.intel.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: * On Wednesday 08 Oct 2008 12:09:20 Sheng Yang wrote: > Signed-off-by: Sheng Yang > --- > arch/x86/kvm/x86.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 675fcc1..c5763d7 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -176,7 +176,9 @@ static void kvm_free_assigned_device(struct kvm *kvm, > if (irqchip_in_kernel(kvm) && assigned_dev->irq_requested) > free_irq(assigned_dev->host_irq, (void *)assigned_dev); > > - kvm_unregister_irq_ack_notifier(kvm, &assigned_dev->ack_notifier); > + if (irqchip_in_kernel(kvm)) > + kvm_unregister_irq_ack_notifier(kvm, > + &assigned_dev->ack_notifier); The unregister API should perform the check whether the said notifier exists so this shouldn't be necessary.