From mboxrd@z Thu Jan  1 00:00:00 1970
From: Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>
Subject: Re: [PATCH] x86 emulator: Add Src2 decode set
Date: Thu, 9 Oct 2008 10:57:44 +0200
Message-ID: <20081009105744.40478c77@frecb000711>
References: <20081008145245.78c7084d@frecb000711>
	<48ECC028.5070807@redhat.com>
	<20081009095253.66737bf1@frecb000711>
	<48EDBCCD.4010705@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: kvm <kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from ecfrec.frec.bull.fr ([129.183.4.8]:49068 "EHLO
	ecfrec.frec.bull.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753675AbYJII5y (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 9 Oct 2008 04:57:54 -0400
In-Reply-To: <48EDBCCD.4010705@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, 09 Oct 2008 10:11:57 +0200
Avi Kivity <avi@redhat.com> wrote:

> Guillaume Thouvenin wrote:
> > Instruction like shld has three operands, so we need to add a Src2
> > decode set. We start with Src2None, Src2CL, and Src2Imm8 to support
> > shld and we will expand it later.
> >
> >   
> 
> Please add Src2One (implied '1') as well, so we can switch the existing
> shift operators to Src2 later.

I will add Src2One but I don't understand exactly what you mean by
switching shift operators to Src2 later. I also applied other remarks,
thanks for your help. The patch follows.