Re: [PATCH] x86 emulator: Add Src2 decode set

Guillaume Thouvenin
2008-10-09T08:57:54Z

On Thu, 09 Oct 2008 10:11:57 +0200
Avi Kivity <avi@redhat.com> wrote:

> Guillaume Thouvenin wrote:
> > Instruction like shld has three operands, so we need to add a Src2
> > decode set. We start with Src2None, Src2CL, and Src2Imm8 to support
> > shld and we will expand it later.
> >
> >
>
> Please add Src2One (implied '1') as well, so we can switch the existing
> shift operators to Src2 later.

I will add Src2One but I don't understand exactly what you mean by
switching shift operators to Src2 later. I also applied other remarks,
thanks for your help. The patch follows.