From: Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>
To: Avi Kivity <avi@redhat.com>
Cc: kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] x86 emulator: Add Src2 decode set
Date: Thu, 9 Oct 2008 11:30:41 +0200 [thread overview]
Message-ID: <20081009113041.714b3fbe@frecb000711> (raw)
In-Reply-To: <48EDC9AA.5010407@redhat.com>
On Thu, 09 Oct 2008 11:06:50 +0200
Avi Kivity <avi@redhat.com> wrote:
>
> The regular shift instructions (shl, rcl, etc) come in three varieties:
> shift by 1, shift by imm8, and shift by CL. Right now they use
> SrcImmByte and decode the implied '1' and CL by hand. If we change them
> to use Src2, they can reuse the Src2CL and Src2One support that you are
> adding now.
Ok I see but shld, rcld, etc come only in two varieties: immediate and
CL. So maybe it could be better to replace SrcImplicit (that is not
really useful) by SrcOne? and then we will have
...
case SrcOne:
c->src.val = 1;
break;
...
and we can reuse Src2CL as well.
next prev parent reply other threads:[~2008-10-09 9:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 12:52 Emulation of shld instruction doesn't work Guillaume Thouvenin
2008-10-08 13:05 ` Guillaume Thouvenin
2008-10-08 14:14 ` Avi Kivity
2008-10-09 7:52 ` [PATCH] x86 emulator: Add Src2 decode set Guillaume Thouvenin
2008-10-09 8:11 ` Avi Kivity
2008-10-09 8:24 ` Avi Kivity
2008-10-09 8:57 ` Guillaume Thouvenin
2008-10-09 9:06 ` Avi Kivity
2008-10-09 9:30 ` Guillaume Thouvenin [this message]
2008-10-09 11:23 ` [PATCH] x86 emulator: Add a Src2 decode set and SrcOne operand type Guillaume Thouvenin
2008-10-22 10:29 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009113041.714b3fbe@frecb000711 \
--to=guillaume.thouvenin@ext.bull.net \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox