Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: "Yang, Sheng" <sheng.yang@intel.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: Avi Kivity <avi@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"Han, Weidong" <weidong.han@intel.com>,
	"Kay, Allen M" <allen.m.kay@intel.com>
Subject: Re: [PATCH 0/4] Enable MSI support for KVM VT-d
Date: Mon, 20 Oct 2008 13:39:32 +0800	[thread overview]
Message-ID: <200810201339.32931.sheng.yang@intel.com> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01B48959@pdsmsx415.ccr.corp.intel.com>

On Monday 20 October 2008 12:09:20 Zhang, Xiantao wrote:
> Avi Kivity wrote:
> > Sheng Yang wrote:
> >> Hi, Avi
> >>
> >> This patchset enable MSI support for KVM VT-d.
> >>
> >> And here are only kernel space ones. The third patch would go to
> >> also goto x86 upstream.
> >>
> >> The userspace code would looks like this:
> >>
> >> assigned_irq_data.guest_msi_addr = *(uint32_t *)(d->msi_cap + 4);
> >> assigned_irq_data.guest_msi_data = *(uint16_t *)(d->msi_cap + 8);
> >> assigned_irq_data.flags |= KVM_DEV_IRQ_ASSIGN_ENABLE_MSI;
> >> r = kvm_assign_irq(kvm_context, &assigned_irq_data);
> >>
> >> I've test the patchset with some userspace hack, it works well.
> >
> > Can you resend this patch with all the updates, as well as the
> > userspace changes?
>
> Maybe Sheng need to make it work on kvm/ia64, and at least the changes
> can't break ia64 side. Xiantao
>
Yes, I would ensure that won't break ia64. I would repost the patchset soon. 

But Avi, for the userspace, the Amit's patch still not checked in, so I 
haven't written a complete version because of lacking code base. I only got a 
experiment patch by hand, expose MSI cap to guest and enable MSI when guest 
wrote MSI enable bit. Well, I prefer to give you a complete version after 
Amit's patch is there. (I will conclude the change of userspace in the first 
mail).

--
regards
Yang, Sheng

      reply	other threads:[~2008-10-20  5:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-26  5:17 [PATCH 0/4] Enable MSI support for KVM VT-d Sheng Yang
2008-10-19 13:16 ` Avi Kivity
2008-10-20  4:09   ` Zhang, Xiantao
2008-10-20  5:39     ` Yang, Sheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810201339.32931.sheng.yang@intel.com \
    --to=sheng.yang@intel.com \
    --cc=allen.m.kay@intel.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=weidong.han@intel.com \
    --cc=xiantao.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox