public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: "Xu, Dongxiao" <dongxiao.xu@intel.com>
Cc: "avi@redhat.com" <avi@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>
Subject: Re: Handle INIT before SIPI.
Date: Wed, 22 Oct 2008 14:48:01 +0200	[thread overview]
Message-ID: <20081022124801.GA14838@redhat.com> (raw)
In-Reply-To: <F4AE3CDE26E0164D9E990A34F2D4E0DF08A8E007F0@pdsmsx502.ccr.corp.intel.com>

On Tue, Oct 21, 2008 at 10:34:12AM +0800, Xu, Dongxiao wrote:
> Hi, Gleb,
>     It seems that this patch is x86 specific, and it breaks the IA-64 compilation. Do you have any good idea to solve this? Thanks!
> 
Solve this by ifdefs for now. For better solution cleanup of SMP
handling is needed.

Signed-off-by: Gleb Natapov <gleb@redhat.com>

diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c
index 67d1de9..c5f3f29 100644
--- a/qemu/qemu-kvm.c
+++ b/qemu/qemu-kvm.c
@@ -353,16 +353,20 @@ static void update_regs_for_sipi(CPUState *env)
 
 static void update_regs_for_init(CPUState *env)
 {
+#ifdef TARGET_I386
     SegmentCache cs = env->segs[R_CS];
+#endif
 
     cpu_reset(env);
 
+#ifdef TARGET_I386
     /* restore SIPI vector */
     if(vcpu_info[env->cpu_index].sipi_needed)
         env->segs[R_CS] = cs;
 
-    kvm_arch_load_regs(env);
     vcpu_info[env->cpu_index].init = 0;
+#endif
+    kvm_arch_load_regs(env);
 }
 
 static void setup_kernel_sigmask(CPUState *env)
--
			Gleb.

      reply	other threads:[~2008-10-22 12:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-16 15:20 Handle INIT before SIPI Gleb Natapov
2008-10-19  9:42 ` Avi Kivity
2008-10-21  2:34 ` Xu, Dongxiao
2008-10-22 12:48   ` Gleb Natapov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081022124801.GA14838@redhat.com \
    --to=gleb@redhat.com \
    --cc=avi@redhat.com \
    --cc=dongxiao.xu@intel.com \
    --cc=kvm-ia64@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox