public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
Cc: kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 0/2] kvm: disable virtualization on kdump
Date: Thu, 23 Oct 2008 17:41:29 -0200	[thread overview]
Message-ID: <20081023194129.GD27959@blackpad> (raw)
In-Reply-To: <20081022232824.GD5247-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>

On Thu, Oct 23, 2008 at 10:28:24AM +1100, Simon Horman wrote:
> On Mon, Oct 20, 2008 at 01:01:32PM -0200, Eduardo Habkost wrote:
> > The following two patches should make kdump work when the kvm-intel module
> > is loaded. We need to disable vmx mode before booting the kdump kernel,
> > so I've introduced a notifier interface where KVM can hook and disable
> > virtualization on all CPUs just before they are halted.
> > 
> > It has the same purpose of the KVM reboot notifier that gets executed
> > at kexec-time. But on the kdump case, things are not as simple because
> > the kernel has just crashed.
> > 
> > The notifier interface being introduced is x86-specific. I don't know
> > if an arch-independent interface would be more appropriate for this
> > case.
> > 
> > It was tested only using kvm-intel. Testing on different machines
> > is welcome.
> 
> These changes look fine to me from a kexec/kdump point of view.
> 
> Reviewed-by: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>

Thanks.

Considering they touch both KVM and kexec, which tree would be best way
to get them in?

(Avi: the patches were sent only to kexec and kvm mailing lists,
initially. If it's better to submit them to your address also so it gets
on your queue, please let me know)

-- 
Eduardo

  parent reply	other threads:[~2008-10-23 19:41 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-20 15:01 [PATCH 0/2] kvm: disable virtualization on kdump Eduardo Habkost
     [not found] ` <1224514894-30171-1-git-send-email-ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-10-20 15:01   ` [PATCH 1/2] kdump: crash-time CPU halt notifier interface Eduardo Habkost
2008-10-20 15:01   ` [PATCH 2/2] kvm: disable virtualization when halting CPUs on crash Eduardo Habkost
2008-10-22 23:28 ` [PATCH 0/2] kvm: disable virtualization on kdump Simon Horman
     [not found]   ` <20081022232824.GD5247-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2008-10-23 19:41     ` Eduardo Habkost [this message]
2008-10-23 22:29       ` Simon Horman
2008-10-24  1:00         ` Eric W. Biederman
     [not found]           ` <m1tzb2hkny.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-26 12:49             ` Avi Kivity
2008-10-26 14:46               ` Eric W. Biederman
     [not found]                 ` <m1mygre7nk.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-26 15:07                   ` Avi Kivity
     [not found]                     ` <490487C1.1010707-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-10-26 21:39                       ` Eduardo Habkost
2008-10-27  2:08                         ` Eric W. Biederman
     [not found]                           ` <m1bpx6bxhm.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-27  9:13                             ` Avi Kivity
     [not found]                               ` <49058645.9010005-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-10-27 12:28                                 ` Eduardo Habkost
2008-10-27 14:02                                   ` Avi Kivity
2008-10-27 17:32                                     ` Eric W. Biederman
     [not found]                                       ` <m18wsa7xl0.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-28 19:45                                         ` Eduardo Habkost
2008-10-28 20:13                                           ` Eric W. Biederman
     [not found]                                             ` <m18ws84gxc.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-29  9:41                                               ` Avi Kivity
     [not found]                                                 ` <49082FD0.3040009-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-10-29 14:54                                                   ` Eric W. Biederman
2008-10-29 17:03                                                     ` Avi Kivity
2008-10-30  1:33                                                       ` Eric W. Biederman
     [not found]                                                         ` <m1bpx23lzg.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-30  7:35                                                           ` Chris Lalancette
     [not found]                                                             ` <490963DF.90703-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-10-30  7:43                                                               ` Avi Kivity
2008-10-30  7:52                                                         ` Avi Kivity
2008-10-29  9:31                                           ` Avi Kivity
2008-10-27 15:05                                 ` Eric W. Biederman
     [not found]                                   ` <m1skqi9iy9.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-27 15:50                                     ` Eduardo Habkost
2008-10-27  8:54                         ` Avi Kivity
     [not found]                           ` <490581A9.80108-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-10-27 13:09                             ` Vivek Goyal
2008-10-27 14:04                               ` Avi Kivity
     [not found]                               ` <20081027130937.GA28226-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-10-29 20:10                                 ` Eduardo Habkost
2008-10-29 20:29                                   ` Avi Kivity
2008-10-29 21:05                                   ` Vivek Goyal
2008-10-30  0:58                                     ` Eric W. Biederman
2008-10-26 21:47                     ` Eric W. Biederman
     [not found]                       ` <m1k5bvc9ku.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-27  8:59                         ` Avi Kivity
2008-10-27 15:02                           ` Eric W. Biederman
     [not found]                             ` <m163neaxo8.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-27 15:38                               ` Eduardo Habkost
2008-10-26 12:46       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081023194129.GD27959@blackpad \
    --to=ehabkost-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
    --cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox