From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muli Ben-Yehuda Subject: Re: [v7] Userspace patches for PCI device assignment Date: Tue, 28 Oct 2008 12:13:34 +0200 Message-ID: <20081028101334.GI7102@il.ibm.com> References: <1224861988-22781-1-git-send-email-amit.shah@redhat.com> <4901F0FE.7070600@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Amit Shah , avi@redhat.com, kvm@vger.kernel.org, weidong.han@intel.com, allen.m.kay@intel.com, Ben-Ami Yassour1 To: Anthony Liguori Return-path: Received: from mtagate2.de.ibm.com ([195.212.17.162]:57426 "EHLO mtagate2.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752615AbYJ1KOS (ORCPT ); Tue, 28 Oct 2008 06:14:18 -0400 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.1/8.13.1) with ESMTP id m9SAEHUE017298 for ; Tue, 28 Oct 2008 10:14:17 GMT Received: from d12av01.megacenter.de.ibm.com (d12av01.megacenter.de.ibm.com [9.149.165.212]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m9SAEGY82707648 for ; Tue, 28 Oct 2008 11:14:17 +0100 Received: from d12av01.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av01.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m9SAEFFv008352 for ; Tue, 28 Oct 2008 11:14:16 +0100 Content-Disposition: inline In-Reply-To: <4901F0FE.7070600@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Oct 24, 2008 at 10:59:58AM -0500, Anthony Liguori wrote: > Amit Shah wrote: >> This patchset enables device assignment for KVM hosts for PCI devices. It >> uses the Intel IOMMU by default if available. >> >> Major changes since the last send in no particular order: >> - formatting changes: adhere to qemu style >> - use strncmp, strncpy etc. instead of the insecure ones >> > > FWIW, strncpy almost never does what you expect it to. snprintf() > is much nicer. Fixed all over. If you find a stray strncpy, shoot it. Cheers, Muli -- The First Workshop on I/O Virtualization (WIOV '08) Dec 2008, San Diego, CA, http://www.usenix.org/wiov08/ <-> SYSTOR 2009---The Israeli Experimental Systems Conference http://www.haifa.il.ibm.com/conferences/systor2009/