From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muli Ben-Yehuda Subject: Re: [PATCH 5/6] device assignment: support for assigning PCI devices to guests Date: Wed, 29 Oct 2008 12:27:38 +0200 Message-ID: <20081029102738.GP6737@il.ibm.com> References: <1225188410-2222-1-git-send-email-muli@il.ibm.com> <1225188410-2222-2-git-send-email-muli@il.ibm.com> <1225188410-2222-3-git-send-email-muli@il.ibm.com> <1225188410-2222-4-git-send-email-muli@il.ibm.com> <1225188410-2222-5-git-send-email-muli@il.ibm.com> <1225188410-2222-6-git-send-email-muli@il.ibm.com> <490733B5.5010102@codemonkey.ws> <20081028155305.GE6737@il.ibm.com> <706158FABBBA044BAD4FE898A02E4BC2140C8163@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Anthony Liguori , "avi@redhat.com" , "kvm@vger.kernel.org" , "Han, Weidong" , Ben-Ami Yassour1 , "amit.shah@redhat.com" , "Kay, Allen M" To: "Zhang, Xiantao" Return-path: Received: from mtagate7.de.ibm.com ([195.212.29.156]:50754 "EHLO mtagate7.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752970AbYJ2K3J (ORCPT ); Wed, 29 Oct 2008 06:29:09 -0400 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id m9TASLOu039364 for ; Wed, 29 Oct 2008 10:28:21 GMT Received: from d12av01.megacenter.de.ibm.com (d12av01.megacenter.de.ibm.com [9.149.165.212]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m9TASLj82629836 for ; Wed, 29 Oct 2008 11:28:21 +0100 Received: from d12av01.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av01.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m9TASKV5025234 for ; Wed, 29 Oct 2008 11:28:21 +0100 Content-Disposition: inline In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC2140C8163@pdsmsx503.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Oct 29, 2008 at 03:56:54PM +0800, Zhang, Xiantao wrote: > Muli Ben-Yehuda wrote: > > On Tue, Oct 28, 2008 at 10:45:57AM -0500, Anthony Liguori wrote: > > > >>> +ifeq ($(USE_KVM), 1) > >>> +OBJS+= device-assignment.o > >>> +endif > >> > >> I don't think you want to build this on PPC so I think you need a > >> stronger check. > > > > Good point. How about checking TARGET_BASE_ARCH = i386? > > It should work for ia64, please include ia64 when you do it in this > way. Fixing it to work for ia64 will take a few more changes than just this, and I'd rather not do it now. This patchset has been through a tremendous amount of churn, and I hope it can finally find its way into the tree now. Once it's in, adding ia64 support will be a lot simpler. Cheers, Muli -- The First Workshop on I/O Virtualization (WIOV '08) Dec 2008, San Diego, CA, http://www.usenix.org/wiov08/ <-> SYSTOR 2009---The Israeli Experimental Systems Conference http://www.haifa.il.ibm.com/conferences/systor2009/