From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muli Ben-Yehuda Subject: Re: [PATCH 5/6] device assignment: support for assigning PCI devices to guests Date: Wed, 29 Oct 2008 13:47:59 +0200 Message-ID: <20081029114759.GA6828@il.ibm.com> References: <1225188410-2222-1-git-send-email-muli@il.ibm.com> <1225188410-2222-2-git-send-email-muli@il.ibm.com> <1225188410-2222-3-git-send-email-muli@il.ibm.com> <1225188410-2222-4-git-send-email-muli@il.ibm.com> <1225188410-2222-5-git-send-email-muli@il.ibm.com> <1225188410-2222-6-git-send-email-muli@il.ibm.com> <1225212922.11515.85.camel@blaa> <20081029103102.GQ6737@il.ibm.com> <1225278910.7615.5.camel@blaa> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: avi@redhat.com, kvm@vger.kernel.org, anthony@codemonkey.ws, weidong.han@intel.com, Ben-Ami Yassour1 , amit.shah@redhat.com, allen.m.kay@intel.com To: Mark McLoughlin Return-path: Received: from mtagate5.de.ibm.com ([195.212.29.154]:52645 "EHLO mtagate5.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753078AbYJ2LuE (ORCPT ); Wed, 29 Oct 2008 07:50:04 -0400 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id m9TBmu6F253472 for ; Wed, 29 Oct 2008 11:48:56 GMT Received: from d12av04.megacenter.de.ibm.com (d12av04.megacenter.de.ibm.com [9.149.165.229]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m9TBmu822363482 for ; Wed, 29 Oct 2008 12:48:56 +0100 Received: from d12av04.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av04.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m9TBmtfN005513 for ; Wed, 29 Oct 2008 12:48:56 +0100 Content-Disposition: inline In-Reply-To: <1225278910.7615.5.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Oct 29, 2008 at 11:15:10AM +0000, Mark McLoughlin wrote: > On Wed, 2008-10-29 at 12:31 +0200, Muli Ben-Yehuda wrote: > > On Tue, Oct 28, 2008 at 04:55:22PM +0000, Mark McLoughlin wrote: > > > > nr_assigned_devices isn't actually used anywhere. > > > > Nuked. > > Still there. > > > > > +#define MAX_IO_REGIONS (6) > > > > > > Perhaps a comment to say this is the number of BARs in the config space > > > header? > > > > Sure, comments are cheap. > > You didn't add one though :-) > > > > > + > > > > + if (kvm_enabled() && device_assignment_enabled) { > > > > > > The device_assignment_enabled flag looks like it shouldn't be needed. > > > > > > If assigned_devices_index remains zero, nothing should happen > > > anyway. > > > > Nuked. > > Still there. Sorry, I messed up the rebase! v10 coming up in a few minutes. Cheers, Muli -- The First Workshop on I/O Virtualization (WIOV '08) Dec 2008, San Diego, CA, http://www.usenix.org/wiov08/ <-> SYSTOR 2009---The Israeli Experimental Systems Conference http://www.haifa.il.ibm.com/conferences/systor2009/