Re: [PATCH 5/6] device assignment: support for assigning PCI devices to guests

Mark McLoughlin
2008-10-29T11:17:14Z

On Wed, 2008-10-29 at 12:31 +0200, Muli Ben-Yehuda wrote:
> On Tue, Oct 28, 2008 at 04:55:22PM +0000, Mark McLoughlin wrote:

> > nr_assigned_devices isn't actually used anywhere.
>
> Nuked.

Still there.

> > > +#define MAX_IO_REGIONS (6)
> >
> > Perhaps a comment to say this is the number of BARs in the config space
> > header?
>
> Sure, comments are cheap.

You didn't add one though :-)

> > > +
> > > + if (kvm_enabled() && device_assignment_enabled) {
> >
> > The device_assignment_enabled flag looks like it shouldn't be needed.
> >
> > If assigned_devices_index remains zero, nothing should happen
> > anyway.
>
> Nuked.

Still there.

Cheers,
Mark.