From mboxrd@z Thu Jan  1 00:00:00 1970
From: Glauber Costa <glommer@redhat.com>
Subject: Re: [PATCH 3/3] Add KVM support to QEMU
Date: Wed, 29 Oct 2008 15:41:22 -0200
Message-ID: <20081029174122.GE11532@poweredge.glommer>
References: <1225224814-9875-1-git-send-email-aliguori@us.ibm.com> <1225224814-9875-2-git-send-email-aliguori@us.ibm.com> <1225224814-9875-3-git-send-email-aliguori@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>,
	kvm-devel <kvm@vger.kernel.org>
To: Anthony Liguori <aliguori@us.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:46354 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753323AbYJ2Rjp (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 29 Oct 2008 13:39:45 -0400
Content-Disposition: inline
In-Reply-To: <1225224814-9875-3-git-send-email-aliguori@us.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

resending, now with less quoted text:

> diff --git a/kvm-all.c b/kvm-all.c
> new file mode 100644
> index 0000000..4379071
> --- /dev/null
> +++ b/kvm-all.c
> @@ -0,0 +1,377 @@
> +/*
> + * QEMU KVM support
> + *
> + * Copyright IBM, Corp. 2008
> + *
> + * Authors:
> + *  Anthony Liguori   <aliguori@us.ibm.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + *
> + */
> +
> +#include <sys/types.h>
> +#include <sys/ioctl.h>
> +#include <sys/mman.h>
> +
> +#include <linux/kvm.h>
> +
> +#include "qemu-common.h"
> +#include "sysemu.h"
> +#include "kvm.h"
> +
> +//#define DEBUG_KVM
> +
> +#ifdef DEBUG_KVM
> +#define dprintf(fmt, ...) \
> +    do { fprintf(stderr, fmt, ## __VA_ARGS__); } while (0)
> +#else
> +#define dprintf(fmt, ...) \
> +    do { } while (0)
> +#endif
> +
> +typedef struct kvm_userspace_memory_region KVMSlot;

Actually, I don't think it is a good idea.
We may want to keep internal-only data tied to the slot, such the slot's
dirty bitmap if we do per-slot dirty tracking.

Of course there may be other ways to do it, but this is the cleaner
and more adequate since we're going through a fresh start.