From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Habkost Subject: Re: [PATCH 1/6] kdump: crash-time virt disable function Date: Thu, 30 Oct 2008 14:24:42 -0200 Message-ID: <20081030162442.GW23893@blackpad> References: <1225373687-6960-1-git-send-email-ehabkost@redhat.com> <1225373687-6960-2-git-send-email-ehabkost@redhat.com> <4909BBA7.1020307@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Haren Myneni , Simon Horman , "Eric W. Biederman" , Vivek Goyal To: Avi Kivity Return-path: Content-Disposition: inline In-Reply-To: <4909BBA7.1020307-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kexec-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: kvm.vger.kernel.org On Thu, Oct 30, 2008 at 03:50:31PM +0200, Avi Kivity wrote: >> >> +static void (*virt_disable_fn)(unsigned int cpu); >> > > Since you never use the cpu argument, I suggest dropping it. It is a leftover from when I was using cpus_hardware_enabled to check if vmx was enabled, before I've noticed I could just check CR4.VMXE. I will drop it. -- Eduardo