From: Sheng Yang <sheng@linux.intel.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 06/10] KVM: Export ioapic_get_delivery_bitmask
Date: Tue, 4 Nov 2008 19:09:31 +0800 [thread overview]
Message-ID: <200811041909.31795.sheng@linux.intel.com> (raw)
In-Reply-To: <49102CE7.7020401@redhat.com>
On Tuesday 04 November 2008 19:07:19 Avi Kivity wrote:
> Sheng Yang wrote:
> > It would be used for MSI in device assignment, for MSI dispatch.
> >
> > -static u32 ioapic_get_delivery_bitmask(struct kvm_ioapic *ioapic, u8
> > dest, - u8 dest_mode)
> > +u32 ioapic_get_delivery_bitmask(struct kvm_ioapic *ioapic, u8 dest,
> > + u8 dest_mode)
>
> Need to be prefixed with kvm_, otherwise it might be confused with the
> host ioapic.
>
> I'm a little worried about locking; we'll want to have a separate lock
> for the ioapic, and callers of this function will need to know about
> it. But we can handle that later.
Yeah, agree. And after kvm_apic_local_deliver() was exported, I also a little
worry about locking on apic side. I would like take a look at them later.
--
regards
Yang, Sheng
next prev parent reply other threads:[~2008-11-04 11:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 4:50 [PATCH 0/10][v4] Enable MSI for KVM assigned device kernel part Sheng Yang
2008-10-31 4:50 ` [PATCH 01/10] KVM: Move ack notifier register and IRQ sourcd ID request Sheng Yang
2008-10-31 4:50 ` [PATCH 02/10] KVM: Separate update irq to a single function Sheng Yang
2008-10-31 4:50 ` [PATCH 03/10] KVM: Replace irq_requested with more generic irq_requested_type Sheng Yang
2008-10-31 4:50 ` [PATCH 04/10] KVM: Clean up assigned_device_update_irq Sheng Yang
2008-10-31 4:50 ` [PATCH 05/10] KVM: Add fields for MSI device assignment Sheng Yang
2008-11-04 11:05 ` Avi Kivity
2008-10-31 4:50 ` [PATCH 06/10] KVM: Export ioapic_get_delivery_bitmask Sheng Yang
2008-11-04 11:07 ` Avi Kivity
2008-11-04 11:09 ` Sheng Yang [this message]
2008-10-31 4:50 ` [PATCH 07/10] x86: Add MSI delivery mode value Sheng Yang
2008-11-04 11:09 ` Avi Kivity
2008-11-04 11:37 ` Sheng Yang
2008-10-31 4:50 ` [PATCH 08/10] KVM: Add assigned_device_msi_dispatch() Sheng Yang
2008-11-04 11:17 ` Avi Kivity
2008-11-04 11:17 ` Sheng Yang
2008-10-31 4:50 ` [PATCH 09/10] KVM: Enable MSI for device assignment Sheng Yang
2008-11-04 11:23 ` Avi Kivity
2008-11-04 13:25 ` Sheng Yang
2008-11-04 13:32 ` Avi Kivity
2008-11-04 13:58 ` Sheng Yang
2008-11-04 14:35 ` Avi Kivity
2008-11-04 14:57 ` Sheng Yang
2008-11-04 15:01 ` Avi Kivity
2008-11-04 15:14 ` Sheng Yang
2008-10-31 4:50 ` [PATCH 10/10] KVM: MSI to INTx translate Sheng Yang
2008-11-04 11:25 ` Avi Kivity
2008-11-04 11:40 ` Sheng Yang
2008-11-04 11:57 ` Avi Kivity
2008-11-04 12:55 ` Sheng Yang
-- strict thread matches above, loose matches on Subject: below --
2008-10-30 8:20 [RFC][PATCH 0/10][v3] Enable MSI for KVM assigned device Sheng Yang
2008-10-30 8:20 ` [PATCH 06/10] KVM: Export ioapic_get_delivery_bitmask Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811041909.31795.sheng@linux.intel.com \
--to=sheng@linux.intel.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox