From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH 06/10] KVM: Export ioapic_get_delivery_bitmask Date: Tue, 4 Nov 2008 19:09:31 +0800 Message-ID: <200811041909.31795.sheng@linux.intel.com> References: <1225428647-27614-1-git-send-email-sheng@linux.intel.com> <1225428647-27614-7-git-send-email-sheng@linux.intel.com> <49102CE7.7020401@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mga12.intel.com ([143.182.124.36]:1214 "EHLO azsmga102.ch.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752765AbYKDLMZ (ORCPT ); Tue, 4 Nov 2008 06:12:25 -0500 In-Reply-To: <49102CE7.7020401@redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Tuesday 04 November 2008 19:07:19 Avi Kivity wrote: > Sheng Yang wrote: > > It would be used for MSI in device assignment, for MSI dispatch. > > > > -static u32 ioapic_get_delivery_bitmask(struct kvm_ioapic *ioapic, u8 > > dest, - u8 dest_mode) > > +u32 ioapic_get_delivery_bitmask(struct kvm_ioapic *ioapic, u8 dest, > > + u8 dest_mode) > > Need to be prefixed with kvm_, otherwise it might be confused with the > host ioapic. > > I'm a little worried about locking; we'll want to have a separate lock > for the ioapic, and callers of this function will need to know about > it. But we can handle that later. Yeah, agree. And after kvm_apic_local_deliver() was exported, I also a little worry about locking on apic side. I would like take a look at them later. -- regards Yang, Sheng