From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH 07/10] x86: Add MSI delivery mode value Date: Tue, 4 Nov 2008 19:37:10 +0800 Message-ID: <200811041937.11126.sheng@linux.intel.com> References: <1225428647-27614-1-git-send-email-sheng@linux.intel.com> <1225428647-27614-8-git-send-email-sheng@linux.intel.com> <49102D5B.7050605@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mga09.intel.com ([134.134.136.24]:57534 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751052AbYKDLkI (ORCPT ); Tue, 4 Nov 2008 06:40:08 -0500 In-Reply-To: <49102D5B.7050605@redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Tuesday 04 November 2008 19:09:15 Avi Kivity wrote: > Sheng Yang wrote: > > Signed-off-by: Sheng Yang > > --- > > arch/x86/include/asm/msidef.h | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/arch/x86/include/asm/msidef.h > > b/arch/x86/include/asm/msidef.h index 6706b30..32edc7f 100644 > > --- a/arch/x86/include/asm/msidef.h > > +++ b/arch/x86/include/asm/msidef.h > > @@ -17,6 +17,8 @@ > > #define MSI_DATA_DELIVERY_MODE_SHIFT 8 > > #define MSI_DATA_DELIVERY_FIXED (0 << MSI_DATA_DELIVERY_MODE_SHIFT) > > #define MSI_DATA_DELIVERY_LOWPRI (1 << MSI_DATA_DELIVERY_MODE_SHIFT) > > +#define MSI_DATA_DELIVERY_FIXED_VAL 0 > > +#define MSI_DATA_DELIVERY_LOWPRI_VAL 1 > > Shouldn't _FIXED be defined in terms of _FIXED_VAL then? Yes... It's a compromise... Well, if you think it's OK, I would make it more elegant (rename macro on host side, I would do the same thing to IA64 sooner or later). -- regards Yang, Sheng