public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org, avi@redhat.com, kraxel@redhat.com,
	anthony@codemonkey.ws, Sander.Vanleeuwen@sun.com,
	zach@vmware.com, brogers@novell.com
Subject: Re: [PATCH] Activate Virtualization On Demand v2
Date: Wed, 5 Nov 2008 14:06:34 +0100	[thread overview]
Message-ID: <200811051406.34227.borntraeger@de.ibm.com> (raw)
In-Reply-To: <1225874896-13186-1-git-send-email-agraf@suse.de>

Am Mittwoch, 5. November 2008 schrieb Alexander Graf:
>  		printk(KERN_INFO "kvm: disabling virtualization on CPU%d\n",
>  		       cpu);
[...]
>  		printk(KERN_INFO "kvm: disabling virtualization on CPU%d\n",
>  		       cpu);
[...]
>  		printk(KERN_INFO "kvm: enabling virtualization on CPU%d\n",
>  		       cpu);
[...]
>  		printk(KERN_INFO "kvm: exiting hardware virtualization\n");

When you are at it, could move these printk to the arches that atually 
enable/disable virtualization?

For example you could do something like 
if (callback) {
	printk "...";
	callback();
}

And then you could remove kvm_arch_hardware_enable/disable from s390 and 
powerpc.

Havng these messages on s390 and powerpc makes absolutely no sense.

  parent reply	other threads:[~2008-11-05 13:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-05  8:48 [PATCH] Activate Virtualization On Demand v2 Alexander Graf
2008-11-05 10:06 ` Avi Kivity
2008-11-05 10:28   ` Alexander Graf
2008-11-05 10:45     ` Avi Kivity
2008-11-05 10:53       ` Alexander Graf
2008-11-05 11:23       ` Alexander Graf
2008-11-05 10:45 ` Zhang, Xiantao
2008-11-05 10:54   ` Alexander Graf
2008-11-05 10:58 ` Daniel P. Berrange
2008-11-05 11:01   ` Alexander Graf
2008-11-05 13:06 ` Christian Borntraeger [this message]
2008-11-05 13:12   ` Avi Kivity
  -- strict thread matches above, loose matches on Subject: below --
2009-06-15 11:30 Alexander Graf
2009-06-15 12:17 ` Christoph Hellwig
2009-06-15 12:25   ` Alexander Graf
2009-06-15 12:27     ` Christoph Hellwig
2009-06-16 14:02   ` Avi Kivity
2009-06-16 14:01 ` Avi Kivity
2009-06-16 14:08   ` Alexander Graf
2009-06-16 15:13     ` Avi Kivity
2009-06-17 21:56       ` Alexander Graf
2009-06-18  8:35         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811051406.34227.borntraeger@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=Sander.Vanleeuwen@sun.com \
    --cc=agraf@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=brogers@novell.com \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox