From: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
To: Eduardo Habkost <ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>,
kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>,
Haren Myneni <hbabu-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Andrey Borzenkov <arvidjaar-JGs/UdohzUI@public.gmane.org>,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Eric W. Biederman"
<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 15/15] Revert "x86: default to reboot via ACPI"
Date: Thu, 6 Nov 2008 08:14:45 +0100 [thread overview]
Message-ID: <20081106071445.GI15731@elte.hu> (raw)
In-Reply-To: <1225915018-6548-16-git-send-email-ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
* Eduardo Habkost <ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> This reverts commit c7ffa6c26277b403920e2255d10df849bd613380.
>
> Now that we have the hooks to disable virtualization on
> emergency_restart(), we can get back to the BOOT_KBD reboot_type default.
>
> Signed-off-by: Eduardo Habkost <ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
hm, why revert this? There's nothing wrong with the ACPI reboot
method, it's just that we surprise the BIOS by exiting with an unclean
VMX state in certain circumstances.
if the ACPI reboot method does not work we do the KBD method as the
next thing in the reboot chain.
Ingo
next prev parent reply other threads:[~2008-11-06 7:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 19:56 [PATCH 00/15] x86: disable virt on kdump and emergency_restart (v2) Eduardo Habkost
[not found] ` <1225915018-6548-1-git-send-email-ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-11-05 19:56 ` [PATCH 01/15] x86 kdump: Extract kdump-specific code from crash_nmi_callback() Eduardo Habkost
2008-11-05 19:56 ` [PATCH 02/15] x86 kdump: Move crashing_cpu assignment to nmi_shootdown_cpus() Eduardo Habkost
2008-11-05 19:56 ` [PATCH 03/15] x86 kdump: Create kdump_nmi_shootdown_cpus() Eduardo Habkost
2008-11-05 19:56 ` [PATCH 04/15] x86 kdump: Make kdump_nmi_callback() a function ptr on crash_nmi_callback() Eduardo Habkost
2008-11-05 19:56 ` [PATCH 05/15] x86 kdump: Make nmi_shootdown_cpus() non-static Eduardo Habkost
2008-11-05 19:56 ` [PATCH 06/15] x86: Move nmi_shootdown_cpus() to reboot.c Eduardo Habkost
2008-11-05 19:56 ` [PATCH 07/15] x86: Make nmi_shootdown_cpus() available on !SMP and !X86_LOCAL_APIC Eduardo Habkost
2008-11-05 19:56 ` [PATCH 08/15] x86: Disable IRQs before doing anything on nmi_shootdown_cpus() Eduardo Habkost
2008-11-05 19:56 ` [PATCH 09/15] x86: Emergency virtualization disable function Eduardo Habkost
2008-11-05 22:27 ` Pavel Machek
[not found] ` <20081105222731.GA14202-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2008-11-06 15:34 ` Eduardo Habkost
2008-11-06 18:11 ` Pavel Machek
2008-11-05 19:56 ` [PATCH 10/15] kdump: Hook emergency_virt_disable() on crash shutdown code Eduardo Habkost
2008-11-05 19:56 ` [PATCH 11/15] x86: disable virtualization on all CPUs if needed, on emergency_restart Eduardo Habkost
2008-11-05 19:56 ` [PATCH 12/15] kvm: svm: no-parameters version of svm_hardware_disable() Eduardo Habkost
2008-11-05 19:56 ` [PATCH 13/15] kvm: svm: register virt_disable function on hardware_setup Eduardo Habkost
2008-11-05 19:56 ` [PATCH 14/15] kvm: vmx: crash_hardware_disable function Eduardo Habkost
2008-11-05 19:56 ` [PATCH 15/15] Revert "x86: default to reboot via ACPI" Eduardo Habkost
[not found] ` <1225915018-6548-16-git-send-email-ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-11-06 7:14 ` Ingo Molnar [this message]
[not found] ` <20081106071445.GI15731-X9Un+BFzKDI@public.gmane.org>
2008-11-06 12:40 ` Eduardo Habkost
2008-11-06 14:30 ` Ingo Molnar
[not found] ` <20081106143021.GD13023-X9Un+BFzKDI@public.gmane.org>
2008-11-06 15:06 ` Ingo Molnar
2008-11-06 15:41 ` Eric W. Biederman
[not found] ` <m1mygczwtu.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-11-06 15:52 ` Avi Kivity
2008-11-06 15:53 ` Andrey Borzenkov
2008-11-06 19:50 ` Len Brown
2008-11-06 21:50 ` Matthew Garrett
[not found] ` <20081106215011.GA6391-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2008-11-06 22:17 ` Len Brown
2008-11-06 23:24 ` Matthew Garrett
2008-11-07 1:01 ` Zhao Yakui
2008-11-07 0:59 ` Matthew Garrett
[not found] ` <20081107005946.GA9254-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2008-11-09 10:11 ` Avi Kivity
2008-11-09 10:24 ` Matthew Garrett
[not found] <fa.UVpnVba3yRAWG3rGZ0sk20JE9hs@ifi.uio.no>
[not found] ` <fa.FPBNKx3BSvZHPZ+eXD4Tb+fuRYk@ifi.uio.no>
[not found] ` <fa.PvVEuEo+f/t4sLmcGyN2Tsl8zYg@ifi.uio.no>
[not found] ` <fa.zzFdOXisTZzBaE1+ueGIYmt+Z5c@ifi.uio.no>
[not found] ` <fa.vQ6HVRcPFFr1zpcXFFOjEPtDdNk@ifi.uio.no>
[not found] ` <fa.ckUqcrtVKbxAkjNggIdajBTHr9Q@ifi.uio.no>
[not found] ` <fa.ckUqcrtVKbxAkjNggIdajBTHr9Q-6miFZF/5cTBuMpJDpNschA@public.gmane.org>
2008-11-07 1:30 ` Robert Hancock
[not found] ` <49139A43.4000203-fVOoFLC7IWo@public.gmane.org>
2008-11-07 1:43 ` Matthew Garrett
2008-11-07 1:53 ` Len Brown
2008-11-08 22:32 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081106071445.GI15731@elte.hu \
--to=mingo-x9un+bfzkdi@public.gmane.org \
--cc=akpm-3NddpPZAyC0@public.gmane.org \
--cc=arvidjaar-JGs/UdohzUI@public.gmane.org \
--cc=avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hbabu-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
--cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
--cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox