From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 15/15] Revert "x86: default to reboot via ACPI" Date: Thu, 6 Nov 2008 08:14:45 +0100 Message-ID: <20081106071445.GI15731@elte.hu> References: <1225915018-6548-1-git-send-email-ehabkost@redhat.com> <1225915018-6548-16-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Rafael J. Wysocki" , Haren Myneni , Simon Horman , Avi Kivity , Andrey Borzenkov , mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Vivek Goyal , "Eric W. Biederman" To: Eduardo Habkost Return-path: Content-Disposition: inline In-Reply-To: <1225915018-6548-16-git-send-email-ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kexec-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: kvm.vger.kernel.org * Eduardo Habkost wrote: > This reverts commit c7ffa6c26277b403920e2255d10df849bd613380. > > Now that we have the hooks to disable virtualization on > emergency_restart(), we can get back to the BOOT_KBD reboot_type default. > > Signed-off-by: Eduardo Habkost hm, why revert this? There's nothing wrong with the ACPI reboot method, it's just that we surprise the BIOS by exiting with an unclean VMX state in certain circumstances. if the ACPI reboot method does not work we do the KBD method as the next thing in the reboot chain. Ingo