From: Hollis Blanchard <hollisb@us.ibm.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: Anthony Liguori <anthony@codemonkey.ws>,
"rusty@rustcorp.com.au" <rusty@rustcorp.com.au>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
"kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>
Subject: Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT
Date: Thu, 6 Nov 2008 23:05:03 -0600 [thread overview]
Message-ID: <200811062305.03494.hollisb@us.ibm.com> (raw)
In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC21983F577@pdsmsx503.ccr.corp.intel.com>
On Thursday 06 November 2008 19:38:40 Zhang, Xiantao wrote:
>
> Hi, Hollis
> Currenlty, kvm-qemu only supports the only case which is host page_size =
qemu's target page size for ia64. Does your patch meets the requirement ? For
ia64, current linux support 4K, 16K and 64k page size, and 1M 16M 64M or
bigger page will be supported in future, so if your patch consider the case,
it should work for ia64. Thanks!
Take a look at the patch and you tell me. :) I've hardcoded the PFN shift as
16, which matches your TARGET_PAGE_BITS, but does it *have* to be the same? I
don't believe it does.
Out of curiosity, if you had 4K Linux host pages, and you redefined
TARGET_PAGE_BITS to be 12, would everything just work?
Also, as long as I have you... can we use getpagesize() instead of 65536/4096
in qemu_vmalloc()?
--
Hollis Blanchard
IBM Linux Technology Center
next prev parent reply other threads:[~2008-11-07 5:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 4:49 [PATCH] qemu: define and use VIRTIO_PFN_SHIFT Hollis Blanchard
[not found] ` <43a111ea61b542d3823e.1225946995-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-11-06 10:54 ` Mark McLoughlin
2008-11-06 14:01 ` Anthony Liguori
[not found] ` <4912F89D.1090908-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2008-11-06 19:02 ` Hollis Blanchard
2008-11-06 20:02 ` Anthony Liguori
[not found] ` <49134D42.6080109-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2008-11-06 23:27 ` dynamic virtio page size Hollis Blanchard
[not found] ` <1226014074.8620.69.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-11-06 23:32 ` Hollis Blanchard
2008-11-07 1:38 ` [PATCH] qemu: define and use VIRTIO_PFN_SHIFT Zhang, Xiantao
2008-11-07 5:05 ` Hollis Blanchard [this message]
[not found] ` <200811062305.03494.hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-11-10 5:55 ` Zhang, Xiantao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811062305.03494.hollisb@us.ibm.com \
--to=hollisb@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=kvm-ia64@vger.kernel.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox