From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT Date: Thu, 6 Nov 2008 23:05:03 -0600 Message-ID: <200811062305.03494.hollisb@us.ibm.com> References: <43a111ea61b542d3823e.1225946995@localhost.localdomain> <1225998124.8620.45.camel@localhost.localdomain> <706158FABBBA044BAD4FE898A02E4BC21983F577@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , "rusty@rustcorp.com.au" , "kvm@vger.kernel.org" , "kvm-ppc@vger.kernel.org" , "kvm-ia64@vger.kernel.org" To: "Zhang, Xiantao" Return-path: Received: from e6.ny.us.ibm.com ([32.97.182.146]:36898 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745AbYKGFF0 (ORCPT ); Fri, 7 Nov 2008 00:05:26 -0500 In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC21983F577@pdsmsx503.ccr.corp.intel.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Thursday 06 November 2008 19:38:40 Zhang, Xiantao wrote: > > Hi, Hollis > Currenlty, kvm-qemu only supports the only case which is host page_size = qemu's target page size for ia64. Does your patch meets the requirement ? For ia64, current linux support 4K, 16K and 64k page size, and 1M 16M 64M or bigger page will be supported in future, so if your patch consider the case, it should work for ia64. Thanks! Take a look at the patch and you tell me. :) I've hardcoded the PFN shift as 16, which matches your TARGET_PAGE_BITS, but does it *have* to be the same? I don't believe it does. Out of curiosity, if you had 4K Linux host pages, and you redefined TARGET_PAGE_BITS to be 12, would everything just work? Also, as long as I have you... can we use getpagesize() instead of 65536/4096 in qemu_vmalloc()? -- Hollis Blanchard IBM Linux Technology Center