From: Matthew Garrett <mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Robert Hancock <hancockr-fVOoFLC7IWo@public.gmane.org>
Cc: Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>,
"Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>,
"Eric W. Biederman"
<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
Eduardo Habkost
<ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Zhao Yakui <yakui.zhao-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>,
Andrey Borzenkov <arvidjaar-JGs/UdohzUI@public.gmane.org>,
Len Brown <lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 15/15] Revert "x86: default to reboot via ACPI"
Date: Fri, 7 Nov 2008 01:43:42 +0000 [thread overview]
Message-ID: <20081107014342.GA9841@srcf.ucam.org> (raw)
In-Reply-To: <49139A43.4000203-fVOoFLC7IWo@public.gmane.org>
On Thu, Nov 06, 2008 at 07:30:43PM -0600, Robert Hancock wrote:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=8fd145917fb62368a9b80db59562c20576238f5a
>
> This patch ignores the RESET_REG_SUP flag and just tries using the reset
> register anyway if it thinks it's valid. So we may attempt ACPI reset on
> machines which don't indicate it's supported.
Yeah, that sounds very wrong.
> The patch description mentioned that some machines didn't reboot after
> S3 suspend without this patch. However, we recently had this patch merged:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=a68823ee5285e65b51ceb96f8b13a5b4f99a6888
>
> Is it possible that the problem fixed there is the true cause of this
> reboot after S3 problem?
Oh, yeah, could be. Given the From:, I should really have thought of
that :)
--
Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org
next prev parent reply other threads:[~2008-11-07 1:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.UVpnVba3yRAWG3rGZ0sk20JE9hs@ifi.uio.no>
[not found] ` <fa.FPBNKx3BSvZHPZ+eXD4Tb+fuRYk@ifi.uio.no>
[not found] ` <fa.PvVEuEo+f/t4sLmcGyN2Tsl8zYg@ifi.uio.no>
[not found] ` <fa.zzFdOXisTZzBaE1+ueGIYmt+Z5c@ifi.uio.no>
[not found] ` <fa.vQ6HVRcPFFr1zpcXFFOjEPtDdNk@ifi.uio.no>
[not found] ` <fa.ckUqcrtVKbxAkjNggIdajBTHr9Q@ifi.uio.no>
[not found] ` <fa.ckUqcrtVKbxAkjNggIdajBTHr9Q-6miFZF/5cTBuMpJDpNschA@public.gmane.org>
2008-11-07 1:30 ` [PATCH 15/15] Revert "x86: default to reboot via ACPI" Robert Hancock
[not found] ` <49139A43.4000203-fVOoFLC7IWo@public.gmane.org>
2008-11-07 1:43 ` Matthew Garrett [this message]
2008-11-07 1:53 ` Len Brown
2008-11-08 22:32 ` Rafael J. Wysocki
2008-11-05 19:56 [PATCH 00/15] x86: disable virt on kdump and emergency_restart (v2) Eduardo Habkost
[not found] ` <1225915018-6548-1-git-send-email-ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-11-05 19:56 ` [PATCH 15/15] Revert "x86: default to reboot via ACPI" Eduardo Habkost
[not found] ` <1225915018-6548-16-git-send-email-ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-11-06 7:14 ` Ingo Molnar
[not found] ` <20081106071445.GI15731-X9Un+BFzKDI@public.gmane.org>
2008-11-06 12:40 ` Eduardo Habkost
2008-11-06 14:30 ` Ingo Molnar
[not found] ` <20081106143021.GD13023-X9Un+BFzKDI@public.gmane.org>
2008-11-06 15:06 ` Ingo Molnar
2008-11-06 15:41 ` Eric W. Biederman
[not found] ` <m1mygczwtu.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-11-06 15:52 ` Avi Kivity
2008-11-06 15:53 ` Andrey Borzenkov
2008-11-06 19:50 ` Len Brown
2008-11-06 21:50 ` Matthew Garrett
[not found] ` <20081106215011.GA6391-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2008-11-06 22:17 ` Len Brown
2008-11-06 23:24 ` Matthew Garrett
2008-11-07 1:01 ` Zhao Yakui
2008-11-07 0:59 ` Matthew Garrett
[not found] ` <20081107005946.GA9254-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2008-11-09 10:11 ` Avi Kivity
2008-11-09 10:24 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107014342.GA9841@srcf.ucam.org \
--to=mjg-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=akpm-3NddpPZAyC0@public.gmane.org \
--cc=arvidjaar-JGs/UdohzUI@public.gmane.org \
--cc=avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hancockr-fVOoFLC7IWo@public.gmane.org \
--cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-X9Un+BFzKDI@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
--cc=yakui.zhao-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox