public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: "kvm@vger.kernel.org list" <kvm@vger.kernel.org>,
	Avi Kivity <avi@redhat.com>, Elsie Wahlig <elsie.wahlig@amd.com>,
	Anthony Liguori <anthony@codemonkey.ws>,
	"Nakajima, Jun" <jun.nakajima@intel.com>,
	Benjamin Serebrin <benjamin.serebrin@amd.com>
Subject: Re: Cross vendor migration ideas
Date: Wed, 12 Nov 2008 22:22:30 +0530	[thread overview]
Message-ID: <200811122222.30279.amit.shah@redhat.com> (raw)
In-Reply-To: <45680888-AF1B-42B6-B0A7-EE635F44E2A2@suse.de>

Hi Alex,

* On Wednesday 12 Nov 2008 21:09:43 Alexander Graf wrote:
> Hi,
>
> I was thinking a bit about cross vendor migration recently and since
> we're doing open source development, I figured it might be a good idea
> to talk to everyone about this.
>
> So why are we having a problem?
>
> In normal operation we don't. If we're running a 32-bit kernel, we can
> use SYSENTER to jump from kernel<->userspace. If we're on a 64-bit
> kernel with 64-bit userspace, every CPU supports SYSCALL. At least
> Linux is being smart on this and does use exactly these two
> capabilities in these two cases.
> But if we're running in compat mode (64-bit kernel with 32-bit
> userspace), things differ. Intel supports only SYSENTER here, while
> AMD only supports SYSCALL. Both can still use int80.
>
> Operating systems detect usage of SYSCALL or SYSENTER pretty early on
> (Linux does this on vdso). So when we boot up on an Intel machine,
> Linux assumes that using SYSENTER in compat mode is fine. Migrating
> that machine to an AMD machine breaks this assumption though, since
> SYSENTER can't be used in compat mode.
> On LInux, this detection is based on the CPU vendor string. If Linux
> finds a "GenuineIntel", SYSENTER is used in compat mode, if it's
> "AuthenticAMD", SYSCALL is used and if none of these two is found,
> int80 is used.
>
> I tried modifying the vendor string, removed the "overwrite the vendor
> string with the native string" hack and things look like they work
> just fine with Linux.
>
> Unfortunately right now I don't have a 64-bit Windows installation
> around to check if that approach works there too, but if it does and
> no known OS breaks due to the invalid vendor string, we can just
> create our own virtual CPU string, no?

qemu has an option for that, -cpu qemu64 IIRC. As long as we expose 
practically correct cpuids and MSRs, this should be fine. I've not tested 
qemu64 with winxp x64 though. Also, last I knew, winxp x64 installation 
didn't succeed with --no-kvm. qemu by default exposes an AMD CPU type.

There are pros and cons to expose a custom vendor ID:

pros:
- We don't need to have all the cpuid features exposed which are expected of a 
physically available CPU in the market, for example, badly-coded applications 
might crash if we don't have SSSE3 on a Core2Duo. But badly-coded or not, not 
exposing what's actually available on every C2D out there is bad. 

cons:
- To expose the "correct" set of feature bits for a known processor, we also 
need to check the family/model/stepping to support the exact same feature 
bits that were present in the CPU.
- We might not get some optimizations that OSes might have based on CPU type, 
even if the host CPU qualifies for such optimizations
- Standard programs like benchmarking tools, etc., might fail if they depend 
on the vendor string for their functionality

For 32-bit guests, I think exposing a pentium4 or Athlon CPU type should be 
fine. For 64-bit guests, the newer the better.

> I'd love to hear comments and suggestions on this and hope we'll end
> up in a fruitful discussion on how to improve the current situation.

I have a patch ready for emulating sysenter/sysexit on AMD systems (needs 
testing). Patching the guest was an option that was discouraged; I had a hack 
ready but it was quickly shelved (again, untested).

Amit

  parent reply	other threads:[~2008-11-12 16:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-12 15:39 Cross vendor migration ideas Alexander Graf
2008-11-12 15:45 ` Anthony Liguori
2008-11-12 15:50   ` Alexander Graf
2008-11-12 15:59     ` Anthony Liguori
2008-11-13  0:02     ` Skywing
2008-11-13  1:48       ` Serebrin, Benjamin (Calendar)
2008-11-15 13:03         ` Andi Kleen
2008-11-15 16:39           ` Alexander Graf
2008-11-15 17:37             ` Andi Kleen
2008-11-16 15:36               ` Avi Kivity
2008-11-17 11:09                 ` Andi Kleen
2008-11-17 11:59                   ` Avi Kivity
2008-11-15 17:38             ` Glauber Costa
2008-11-16 14:58               ` Avi Kivity
2008-11-13 10:16     ` Avi Kivity
2008-11-12 20:06   ` Andi Kleen
2008-11-12 20:52     ` Alexander Graf
2008-11-13 10:20   ` Avi Kivity
2008-11-12 16:52 ` Amit Shah [this message]
2008-11-12 17:19   ` Alexander Graf
2008-11-13  4:35     ` Amit Shah
2008-11-13 13:38       ` Alexander Graf
2008-11-14 13:07         ` Amit Shah
2008-11-14 23:43           ` Nitin A Kamble
2008-11-17 10:07             ` Amit Shah
  -- strict thread matches above, loose matches on Subject: below --
2008-11-16  0:23 Skywing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811122222.30279.amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=agraf@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=benjamin.serebrin@amd.com \
    --cc=elsie.wahlig@amd.com \
    --cc=jun.nakajima@intel.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox