From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH] Fix kvm-79 userland for separate kernel objdir Date: Thu, 20 Nov 2008 14:48:02 +0100 Message-ID: <20081120134802.GS6703@one.firstfloor.org> References: <20081120131953.GA7629@one.firstfloor.org> <200811201422.04693.borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andi Kleen , kvm@vger.kernel.org To: Christian Borntraeger Return-path: Received: from one.firstfloor.org ([213.235.205.2]:40695 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754183AbYKTNiH (ORCPT ); Thu, 20 Nov 2008 08:38:07 -0500 Content-Disposition: inline In-Reply-To: <200811201422.04693.borntraeger@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Nov 20, 2008 at 02:22:04PM +0100, Christian Borntraeger wrote: > Am Donnerstag, 20. November 2008 schrieb Andi Kleen: > > --- kvm-79/Makefile~ 2008-11-12 12:48:01.000000000 +0100 > > +++ kvm-79/Makefile 2008-11-20 14:06:57.000000000 +0100 > > @@ -33,7 +33,7 @@ > > header-sync-n: > > > > header-sync-y: > > - make -C kernel LINUX=$(KERNELDIR) header-sync > > + make -C kernel LINUX=$(KERNELSOURCEDIR) header-sync > > rm -f kernel/include/asm > > ln -sf asm-$(sane-arch) kernel/include/asm > > Hmm. In my config.mak KERNELSOURCEDIR is empty. Looks like > this patch would break headers_sync on kernels without a separate > objdirs or builds with configure --kerneldir=blah. How about this variant? Does it work for you? -Andi --- kvm-79/Makefile~ 2008-11-12 12:48:01.000000000 +0100 +++ kvm-79/Makefile 2008-11-20 14:36:54.000000000 +0100 @@ -33,7 +33,9 @@ header-sync-n: header-sync-y: - make -C kernel LINUX=$(KERNELDIR) header-sync + make -C kernel \ + LINUX=$(if "$(KERNELSOURCEDIR)",$(KERNELSOURCEDIR),$(KERNELDIR)) \ + header-sync rm -f kernel/include/asm ln -sf asm-$(sane-arch) kernel/include/asm