From: Muli Ben-Yehuda <muli@il.ibm.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org, joro@8bytes.org, anthony@codemonkey.ws,
avi@redhat.com
Subject: Re: [PATCH 07/12] Add VMRUN handler v6
Date: Fri, 21 Nov 2008 17:23:20 +0200 [thread overview]
Message-ID: <20081121152320.GF26684@il.ibm.com> (raw)
In-Reply-To: <1227280482-25361-8-git-send-email-agraf@suse.de>
On Fri, Nov 21, 2008 at 04:14:37PM +0100, Alexander Graf wrote:
> +static int vmrun_interception(struct vcpu_svm *svm, struct kvm_run *kvm_run)
> +{
> + nsvm_printk("VMrun\n");
> + if (nested_svm_check_permissions(svm))
> + return 1;
> +
> + svm->next_rip = kvm_rip_read(&svm->vcpu) + 3;
> + skip_emulated_instruction(&svm->vcpu);
> +
> + if (nested_svm_do(svm, svm->vmcb->save.rax, 0,
> + NULL, nested_svm_vmrun))
> + return 1;
> +
> + if (nested_svm_do(svm, svm->vmcb->control.msrpm_base_pa, 0,
> + NULL, nested_svm_vmrun_msrpm))
> + return 1;
nested_svm_vmrun returns 1 unconditionally, so we never call
nested_svm_vmrun_msrpm.
Cheers,
Muli
--
The First Workshop on I/O Virtualization (WIOV '08)
Dec 2008, San Diego, CA, http://www.usenix.org/wiov08/
<->
SYSTOR 2009---The Israeli Experimental Systems Conference
http://www.haifa.il.ibm.com/conferences/systor2009/
next prev parent reply other threads:[~2008-11-21 15:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 15:14 [PATCH 00/12] Add support for nested SVM (kernel) v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 01/12] Clean up VINTR setting v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 02/12] Move EFER and MSR constants to generic x86 code v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 03/12] Add helper functions for nested SVM v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 04/12] Implement GIF, clgi and stgi v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 05/12] Implement hsave v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 06/12] Add VMLOAD and VMSAVE handlers v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 07/12] Add VMRUN handler v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 08/12] Add VMEXIT handler and intercepts v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 09/12] Allow read access to MSR_VM_VR v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 10/12] Allow setting the SVME bit v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 11/12] Only allow setting of EFER_SVME when CPUID SVM is set v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 12/12] Accelerate nested SVM by emulating parts of GIF=0 v6 Alexander Graf
2008-11-21 16:53 ` Avi Kivity
2008-11-21 16:58 ` Alexander Graf
2008-11-21 17:07 ` Avi Kivity
2008-11-21 17:14 ` Alexander Graf
2008-11-21 17:18 ` Avi Kivity
2008-11-21 17:35 ` Alexander Graf
2008-11-21 15:23 ` Muli Ben-Yehuda [this message]
2008-11-21 15:26 ` [PATCH 07/12] Add VMRUN handler v6 Alexander Graf
2008-11-21 15:35 ` Alexander Graf
2008-11-23 8:06 ` Muli Ben-Yehuda
2008-11-23 13:48 ` Alexander Graf
2008-11-23 15:09 ` Muli Ben-Yehuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081121152320.GF26684@il.ibm.com \
--to=muli@il.ibm.com \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox