From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muli Ben-Yehuda Subject: Re: [PATCH 07/12] Add VMRUN handler v6 Date: Fri, 21 Nov 2008 17:23:20 +0200 Message-ID: <20081121152320.GF26684@il.ibm.com> References: <1227280482-25361-1-git-send-email-agraf@suse.de> <1227280482-25361-2-git-send-email-agraf@suse.de> <1227280482-25361-3-git-send-email-agraf@suse.de> <1227280482-25361-4-git-send-email-agraf@suse.de> <1227280482-25361-5-git-send-email-agraf@suse.de> <1227280482-25361-6-git-send-email-agraf@suse.de> <1227280482-25361-7-git-send-email-agraf@suse.de> <1227280482-25361-8-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, joro@8bytes.org, anthony@codemonkey.ws, avi@redhat.com To: Alexander Graf Return-path: Received: from mtagate7.de.ibm.com ([195.212.29.156]:59547 "EHLO mtagate7.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753487AbYKUPXb (ORCPT ); Fri, 21 Nov 2008 10:23:31 -0500 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id mALFNTfa227558 for ; Fri, 21 Nov 2008 15:23:29 GMT Received: from d12av04.megacenter.de.ibm.com (d12av04.megacenter.de.ibm.com [9.149.165.229]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mALFNTFN4317372 for ; Fri, 21 Nov 2008 16:23:29 +0100 Received: from d12av04.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av04.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mALFNSRI020423 for ; Fri, 21 Nov 2008 16:23:29 +0100 Content-Disposition: inline In-Reply-To: <1227280482-25361-8-git-send-email-agraf@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Nov 21, 2008 at 04:14:37PM +0100, Alexander Graf wrote: > +static int vmrun_interception(struct vcpu_svm *svm, struct kvm_run *kvm_run) > +{ > + nsvm_printk("VMrun\n"); > + if (nested_svm_check_permissions(svm)) > + return 1; > + > + svm->next_rip = kvm_rip_read(&svm->vcpu) + 3; > + skip_emulated_instruction(&svm->vcpu); > + > + if (nested_svm_do(svm, svm->vmcb->save.rax, 0, > + NULL, nested_svm_vmrun)) > + return 1; > + > + if (nested_svm_do(svm, svm->vmcb->control.msrpm_base_pa, 0, > + NULL, nested_svm_vmrun_msrpm)) > + return 1; nested_svm_vmrun returns 1 unconditionally, so we never call nested_svm_vmrun_msrpm. Cheers, Muli -- The First Workshop on I/O Virtualization (WIOV '08) Dec 2008, San Diego, CA, http://www.usenix.org/wiov08/ <-> SYSTOR 2009---The Israeli Experimental Systems Conference http://www.haifa.il.ibm.com/conferences/systor2009/