From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH 07/11] x86: Rename MSI macro name Date: Mon, 24 Nov 2008 10:02:15 +0800 Message-ID: <200811241002.15447.sheng@linux.intel.com> References: <1227095114-13792-1-git-send-email-sheng@linux.intel.com> <1227095114-13792-8-git-send-email-sheng@linux.intel.com> <49292CA6.4060102@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mga05.intel.com ([192.55.52.89]:29880 "EHLO fmsmga101.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751681AbYKXCF4 (ORCPT ); Sun, 23 Nov 2008 21:05:56 -0500 In-Reply-To: <49292CA6.4060102@redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Sunday 23 November 2008 18:12:54 Avi Kivity wrote: > Sheng Yang wrote: > > Signed-off-by: Sheng Yang > > --- > > arch/x86/include/asm/msidef.h | 4 ++-- > > arch/x86/kernel/io_apic.c | 4 ++-- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/arch/x86/include/asm/msidef.h > > b/arch/x86/include/asm/msidef.h index 6706b30..988cb27 100644 > > --- a/arch/x86/include/asm/msidef.h > > +++ b/arch/x86/include/asm/msidef.h > > @@ -15,8 +15,8 @@ > > MSI_DATA_VECTOR_MASK) > > > > #define MSI_DATA_DELIVERY_MODE_SHIFT 8 > > -#define MSI_DATA_DELIVERY_FIXED (0 << MSI_DATA_DELIVERY_MODE_SHIFT) > > -#define MSI_DATA_DELIVERY_LOWPRI (1 << MSI_DATA_DELIVERY_MODE_SHIFT) > > +#define MSI_DATA_DELIVERY_FIXED_BIT (0 << MSI_DATA_DELIVERY_MODE_SHIFT) > > +#define MSI_DATA_DELIVERY_LOWPRI_BIT (1 << > > MSI_DATA_DELIVERY_MODE_SHIFT) > > These are usually named _MASK, not _BIT. But I recommend dropping this > patch, it can only cause conflicts with other development. Yeah, I also don't like this. It's easily cause chaos... I will compromise on it, use IOAPIC_LOWEST_PRIORITY and IOAPIC_FIXED for now, and drop the related two patches. -- regards Yang, Sheng