From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH 09/11] KVM: Add assigned_device_msi_dispatch() Date: Mon, 24 Nov 2008 10:02:44 +0800 Message-ID: <200811241002.44730.sheng@linux.intel.com> References: <1227095114-13792-1-git-send-email-sheng@linux.intel.com> <1227095114-13792-10-git-send-email-sheng@linux.intel.com> <49292EF7.5000707@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mga09.intel.com ([134.134.136.24]:33189 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760AbYKXCG1 (ORCPT ); Sun, 23 Nov 2008 21:06:27 -0500 In-Reply-To: <49292EF7.5000707@redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Sunday 23 November 2008 18:22:47 Avi Kivity wrote: > Sheng Yang wrote: > > The function is used to dispatch MSI to lapic according to MSI message > > address and message data. > > > > + > > + deliver_bitmask = kvm_ioapic_get_delivery_bitmask(ioapic, > > + dest_id, dest_mode); > > + switch (delivery_mode) { > > + case MSI_DATA_DELIVERY_LOWPRI: > > + vcpu = kvm_get_lowest_prio_vcpu(ioapic->kvm, vector, > > + deliver_bitmask); > > + if (vcpu != NULL) > > + kvm_apic_set_irq(vcpu, vector, trig_mode); > > + else > > + printk(KERN_INFO "kvm: null lowest priority vcpu!\n"); > > + break; > > + case MSI_DATA_DELIVERY_FIXED: > > + for (vcpu_id = 0; deliver_bitmask != 0; vcpu_id++) { > > + if (!(deliver_bitmask & (1 << vcpu_id))) > > + continue; > > + deliver_bitmask &= ~(1 << vcpu_id); > > + vcpu = ioapic->kvm->vcpus[vcpu_id]; > > + if (vcpu) > > + kvm_apic_set_irq(vcpu, vector, trig_mode); > > + } > > + break; > > + default: > > This duplicates the ioapic code. That's fine for now, but eventually > we'll want to refactor this. Sure. Put on my todo list... -- regards Yang, Sheng