From: Sheng Yang <yasker@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: Sheng Yang <sheng@linux.intel.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 05/11] KVM: Add fields for MSI device assignment
Date: Tue, 25 Nov 2008 23:07:57 +0800 [thread overview]
Message-ID: <20081125150757.GA32675@yukikaze> (raw)
In-Reply-To: <492C108D.6040209@redhat.com>
On Tue, Nov 25, 2008 at 04:49:49PM +0200, Avi Kivity wrote:
> Avi Kivity wrote:
>>> (In fact, PCI spec defined message data length is u64, but as you
>>> see, now msi_msg for whole Linux only have u32...)
>>>
>>
>> Well in that case please define data as __u64, so we don't have
>> surprises later on.
>>
>
> btw, if you agree with this, don't resend; I'll edit the patch.
Sorry, I found I made a mistake. Intel SDM 3A misleaded me... The PCI spec
defined message data as u16(!!), but Intel SDM 3A got a figure(Figure 8-25) that
reserved all bits up to bit 63, so I thought message data got u64 long...(At
last moment, I remembered the figure on PCI spec and felt something
strange...)
Now I think the latest patchset(v6) is OK to apply.
--
regards
Yang, Sheng
>
> --
> error compiling committee.c: too many arguments to function
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-11-25 15:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 11:45 [PATCH 0/11][v5] Enable MSI for KVM Sheng Yang
2008-11-19 11:45 ` [PATCH 01/11] KVM: Move ack notifier register and IRQ sourcd ID request Sheng Yang
2008-11-23 10:06 ` Avi Kivity
2008-11-19 11:45 ` [PATCH 02/11] KVM: Separate update irq to a single function Sheng Yang
2008-11-23 10:06 ` Avi Kivity
2008-11-19 11:45 ` [PATCH 03/11] KVM: Replace irq_requested with more generic irq_requested_type Sheng Yang
2008-11-23 10:07 ` Avi Kivity
2008-11-19 11:45 ` [PATCH 04/11] KVM: Clean up assigned_device_update_irq Sheng Yang
2008-11-19 11:45 ` [PATCH 05/11] KVM: Add fields for MSI device assignment Sheng Yang
2008-11-23 10:10 ` Avi Kivity
2008-11-24 1:51 ` Sheng Yang
2008-11-25 14:46 ` Avi Kivity
2008-11-25 14:49 ` Avi Kivity
2008-11-25 15:07 ` Sheng Yang [this message]
2008-11-19 11:45 ` [PATCH 06/11] KVM: Export ioapic_get_delivery_bitmask Sheng Yang
2008-11-19 11:45 ` [PATCH 07/11] x86: Rename MSI macro name Sheng Yang
2008-11-23 10:12 ` Avi Kivity
2008-11-24 2:02 ` Sheng Yang
2008-11-19 11:45 ` [PATCH 08/11] x86: Add MSI delivery mode value Sheng Yang
2008-11-19 11:45 ` [PATCH 09/11] KVM: Add assigned_device_msi_dispatch() Sheng Yang
2008-11-23 10:22 ` Avi Kivity
2008-11-24 2:02 ` Sheng Yang
2008-11-19 11:45 ` [PATCH 10/11] KVM: Enable MSI for device assignment Sheng Yang
2008-11-23 10:25 ` Avi Kivity
2008-11-19 11:45 ` [PATCH 11/11] KVM: MSI to INTx translate Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125150757.GA32675@yukikaze \
--to=yasker@gmail.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox