From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [PATCH] Prevent trace call into unloaded module text
Date: Wed, 26 Nov 2008 19:46:19 +0800
Message-ID: <20081126114619.GA15568@localhost>
References: <20081124140427.GA14640@localhost> <492D3063.3030906@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga14.intel.com ([143.182.124.37]:47258 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751741AbYKZLqj (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 26 Nov 2008 06:46:39 -0500
Content-Disposition: inline
In-Reply-To: <492D3063.3030906@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Nov 26, 2008 at 01:17:55PM +0200, Avi Kivity wrote:
> Wu Fengguang wrote:
> > Add marker_synchronize_unregister() before module unloading.
> > This prevents possible trace calls into unloaded module text.
> >
> > Signed-off-by: Wu Fengguang <wfg@linux.intel.com>
> > ---
> > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> > index a87f45e..64f38b3 100644
> > --- a/virt/kvm/kvm_main.c
> > +++ b/virt/kvm/kvm_main.c
> > @@ -2102,5 +2102,6 @@ void kvm_exit(void)
> >  	kvm_arch_exit();
> >  	kvm_exit_debug();
> >  	__free_page(bad_page);
> > +	marker_synchronize_unregister();
> >  }
> >  EXPORT_SYMBOL_GPL(kvm_exit);
> >   
> 
> What about kvm-intel.ko and kvm-amd.ko?  They also contain markers.

vmx_exit and svm_exit() all calls into kvm_exit(), so they have been
handled in a common way.

> (and, why doesn't module unload do this automatically?)

Maybe most modules don't need it for now?

Thanks,
Fengguang