Re: [patch 1/3] QEMU/KVM: x86: separate TSC load from kvm_arch_load_regs

Avi Kivity
2008-12-10T10:10:53Z

> kvm_load_registers is a general interface to load registers, and is
> used by vmport, gdbstub, etc. The TSC MSR is continually counting, so
> it can't be simply read and written back as the other registers/MSR's
> (doing so overwrites the current count).
>
> Introduce kvm_load_tsc and use it for x86's migration CPU load code.
> --- /dev/null
> +++ kvm-userspace.tip/qemu/qemu-kvm-x86.h
> @@ -0,0 +1,13 @@
> +/*
> + * qemu/kvm integration
> + *
> + * Copyright (C) 2006-2008 Qumranet Technologies
>

Qumranet is no more. But please drop this header and just put the
declaration in qemu-kvm.h. We're merging it anyway into qemu upstream
and this is just more more thing we'll need to drop.

--
error compiling committee.c: too many arguments to function