From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCHSETS #2] KVM device passthrough support with AMD IOMMU Date: Mon, 15 Dec 2008 12:29:18 +0100 Message-ID: <20081215112918.GD3407@amd.com> References: <20081209141143.GW12816@amd.com> <493F8D90.40205@redhat.com> <20081210141131.GB12816@amd.com> <1228918928.21454.27.camel@macbook.infradead.org> <20081210142525.GC12816@amd.com> <1228933475.23842.70.camel@macbook.infradead.org> <20081210184240.GH12816@amd.com> <1228934903.23842.75.camel@macbook.infradead.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="1yeeQ81UyVL57Vl7" Cc: Mike Day , Avi Kivity , mingo@redhat.com, weidong.han@intel.com, torvalds@linux-foundation.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: David Woodhouse Return-path: Received: from outbound-dub.frontbridge.com ([213.199.154.16]:37989 "EHLO IE1EHSOBE005.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbYLOL31 (ORCPT ); Mon, 15 Dec 2008 06:29:27 -0500 Content-Disposition: inline In-Reply-To: <1228934903.23842.75.camel@macbook.infradead.org> Sender: kvm-owner@vger.kernel.org List-ID: --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Wed, Dec 10, 2008 at 06:48:23PM +0000, David Woodhouse wrote: > On Wed, 2008-12-10 at 19:42 +0100, Joerg Roedel wrote: > > Ok, I add it, thanks. Who is the author, Mike or you? > > Might as well attribute it to Mike; he spotted it. Ok, here is what I applied, fyi. -- | AMD Saxony Limited Liability Company & Co. KG Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany System | Register Court Dresden: HRA 4896 Research | General Partner authorized to represent: Center | AMD Saxony LLC (Wilmington, Delaware, US) | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset="us-ascii" Content-Disposition: attachment; filename="mike.patch" commit 8876830866c8c9e4471a578a4e474eeef80e98dd Author: Mike Day Date: Fri Dec 12 17:16:30 2008 +0100 intel-iommu: fix bit shift at DOMAIN_FLAG_P2P_MULTIPLE_DEVICES Signed-off-by: Mike Day Signed-off-by: Joerg Roedel diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c index 772fb22..f39af75 100644 --- a/drivers/pci/intel-iommu.c +++ b/drivers/pci/intel-iommu.c @@ -204,7 +204,7 @@ static inline bool dma_pte_present(struct dma_pte *pte) } /* devices under the same p2p bridge are owned in one domain */ -#define DOMAIN_FLAG_P2P_MULTIPLE_DEVICES (1 < 0) +#define DOMAIN_FLAG_P2P_MULTIPLE_DEVICES (1 << 0) /* domain represents a virtual machine, more than one devices * across iommus may be owned in one domain, e.g. kvm guest. --1yeeQ81UyVL57Vl7--