From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH 0/15] Device assignment & MSI enhancement Date: Thu, 25 Dec 2008 17:13:20 +0800 Message-ID: <200812251713.21137.sheng@linux.intel.com> References: <1230196179-6918-1-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti To: kvm@vger.kernel.org Return-path: Received: from mga10.intel.com ([192.55.52.92]:23447 "EHLO fmsmga102.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751548AbYLYJNp (ORCPT ); Thu, 25 Dec 2008 04:13:45 -0500 In-Reply-To: <1230196179-6918-1-git-send-email-sheng@linux.intel.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Thursday 25 December 2008 17:09:24 Sheng Yang wrote: > Hi Avi and Marcelo > > Merry Xmas! And here is the v2 of patchset. Target at 2.6.29 for it > contained a lot of fix and improvement of current device assignment and MSI > feature. > > Change from V1: > > Addressed Marcelo's comments, and: > 1. Fix racy in kvm_free_assigned_irq(). In case to do this, I fetch one > patch (irq_fifo) from original MSI-X patchset. Indeed a nice catch of > Marcelo. > > :) > > 2. Unified kvm_set_irq() with ioapic_deliver(). It didn't save much, but > duplicate is always bothering, and I have modified bitmask for vcpu to a > real bitmap (maybe not all, just what I have seen). Forgot to mention, I didn't change API for guest to disable MSI which is a part of Marcelo's comments, for I think single interface named "update" with some flags represent the current bit state is enough for now... -- regards Yang, Sheng > > And for V1: > > 1. Add gsi_msg mapping mechanism, which gsi can used to indicated a MSI > interrupt.(Notice API/ABI changed a little, but we don't have userspace > patch now, so it should be OK.) > > 2. Provide MSI disable capability. > > arch/x86/kvm/lapic.c | 11 ++- > include/linux/kvm.h | 15 +++- > include/linux/kvm_host.h | 26 +++++- > include/linux/kvm_types.h | 17 ++++ > virt/kvm/ioapic.c | 117 ++++++++++--------------- > virt/kvm/ioapic.h | 23 +---- > virt/kvm/irq_comm.c | 184 ++++++++++++++++++++++++++++++++++++--- > virt/kvm/kvm_main.c | 212 > ++++++++++++++++++++++++++++----------------- 8 files changed, 415 > insertions(+), 190 deletions(-) > > Sorry for the patchset size, it's too easy to grow fast, and I am a little > too lazy to split them into more batches in the Xmas... :) > > -- > regards > Yang, Sheng > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html