From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [patch 2/2] QEMU/KVM: provide an option to disable in-kernel PIT int reinjection Date: Tue, 30 Dec 2008 11:28:29 +0800 Message-ID: <200812301128.29588.sheng@linux.intel.com> References: <20081229174233.165653613@localhost.localdomain> <20081229174406.160714089@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, avi@redhat.com To: Marcelo Tosatti Return-path: Received: from mga06.intel.com ([134.134.136.21]:57908 "EHLO orsmga101.jf.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751541AbYL3D2y (ORCPT ); Mon, 29 Dec 2008 22:28:54 -0500 In-Reply-To: <20081229174406.160714089@localhost.localdomain> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Tuesday 30 December 2008 01:42:35 Marcelo Tosatti wrote: > Signed-off-by: Marcelo Tosatti > >-- > #if defined(TARGET_I386) || defined(TARGET_X86_64) || defined(TARGET_IA64) > || defined(__linux__) { "pcidevice", HAS_ARG, QEMU_OPTION_pcidevice }, > @@ -5267,6 +5270,11 @@ int main(int argc, char **argv, char **e > kvm_pit = 0; > break; > } > + case QEMU_OPTION_kvm_pit_no_reinject: { > + extern int kvm_pit_no_reinject; > + kvm_pit_no_reinject = 1; > + break; > + } > case QEMU_OPTION_enable_nesting: { > kvm_nested = 1; > break; Do we need check the conflict of --kvm-pit-no-reinject and --no-kvm-pit/--no- kvm-irqchip? Check it ahead of kvm_qemu_create_context() seems a little better... -- regards Yang, Sheng