Re: [PATCH 1/3] KVM: Add MSI_ACTION flag for assigned irq

Avi Kivity
2008-12-30T10:19:34Z

Sheng Yang wrote:
> For MSI disable feature later.
>
> Notice I changed ABI here, but due to no userspace patch, I think it's OK.
>

It's not okay, since eventually we will have userspace and it will have
to work with older kernels as well.

No released kernel has KVM_DEV_IRQ_ASSIGN_ENABLE_MSI, so it's fine,
provided I fold this into the 2.6.29 submission. However, why do this
at all? It can only cause confusion.

--
error compiling committee.c: too many arguments to function