Re: [PATCH 1/3] KVM: Add MSI_ACTION flag for assigned irq

Avi Kivity
2008-12-30T10:41:58Z

Sheng Yang wrote:
>>> MASK_MSIX, and UNMASK, every two action are in pairs but we have to use
>>> twice bits to store them. So I'd like to use MSI_ACTION approach...
>>>
>> Well, it you have flags without ENABLE_MSI, doesn't it imply DISABLE_MSI?
>>
>> The structure contains the state we want to reach, not a command we wish
>> the kernel to perform.
>>
>
> Yes, that's what I want. But check more than one flags(for MSI-X) to determine
> where to go is not that clear. So I add a flag here to indicate the operation
> type which I think is a little more clear.
>

Don't understand. Do you mean MSI and MSI-X are mutually exclusive?

If so, we can add a comment.

--
error compiling committee.c: too many arguments to function