From: Gleb Natapov <gleb@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Avi Kivity <avi@redhat.com>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm: bios: KVM does not support SMM, so disable it
Date: Wed, 31 Dec 2008 08:45:49 +0200 [thread overview]
Message-ID: <20081231064549.GD3326@redhat.com> (raw)
In-Reply-To: <495A4D85.7020305@codemonkey.ws>
On Tue, Dec 30, 2008 at 10:34:13AM -0600, Anthony Liguori wrote:
> Avi Kivity wrote:
>> From: Gleb Natapov <gleb@redhat.com>
>>
>> Signed-off-by: Gleb Natapov <gleb@redhat.com>
>> Signed-off-by: Avi Kivity <avi@redhat.com>
>>
>> diff --git a/bios/rombios32.c b/bios/rombios32.c
>> index fd6ff71..a0c9572 100755
>> --- a/bios/rombios32.c
>> +++ b/bios/rombios32.c
>> @@ -38,7 +38,7 @@ typedef unsigned long long uint64_t;
>> //#define BX_USE_EBDA_TABLES
>> /* define it if the (emulated) hardware supports SMM mode */
>> -#define BX_USE_SMM
>> +//#define BX_USE_SMM
>>
>
> We already disable SMM in acpi.c:piix4_pm_init() by setting the SMM
> inited bit in the PCI config space for the piix4. It's hackish, but it
> avoids needing a KVM-specific BIOS.
>
Then something is broken there right now since without the comment
Windows does not resumes. I'll check.
--
Gleb.
prev parent reply other threads:[~2008-12-31 6:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081230150725.4E4C925000A@cleopatra.tlv.redhat.com>
2008-12-30 16:34 ` [PATCH] kvm: bios: KVM does not support SMM, so disable it Anthony Liguori
2008-12-31 6:45 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081231064549.GD3326@redhat.com \
--to=gleb@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox