From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH] kvm: bios: KVM does not support SMM, so disable it
Date: Wed, 31 Dec 2008 08:45:49 +0200
Message-ID: <20081231064549.GD3326@redhat.com>
References: <20081230150725.4E4C925000A@cleopatra.tlv.redhat.com> <495A4D85.7020305@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, kvm-devel <kvm@vger.kernel.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:59845 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751993AbYLaGos (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 31 Dec 2008 01:44:48 -0500
Content-Disposition: inline
In-Reply-To: <495A4D85.7020305@codemonkey.ws>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Dec 30, 2008 at 10:34:13AM -0600, Anthony Liguori wrote:
> Avi Kivity wrote:
>> From: Gleb Natapov <gleb@redhat.com>
>>
>> Signed-off-by: Gleb Natapov <gleb@redhat.com>
>> Signed-off-by: Avi Kivity <avi@redhat.com>
>>
>> diff --git a/bios/rombios32.c b/bios/rombios32.c
>> index fd6ff71..a0c9572 100755
>> --- a/bios/rombios32.c
>> +++ b/bios/rombios32.c
>> @@ -38,7 +38,7 @@ typedef unsigned long long uint64_t;
>>  //#define BX_USE_EBDA_TABLES
>>   /* define it if the (emulated) hardware supports SMM mode */
>> -#define BX_USE_SMM
>> +//#define BX_USE_SMM
>>   
>
> We already disable SMM in acpi.c:piix4_pm_init() by setting the SMM  
> inited bit in the PCI config space for the piix4.  It's hackish, but it  
> avoids needing a KVM-specific BIOS.
>
Then something is broken there right now since without the comment
Windows does not resumes. I'll check.

--
			Gleb.