From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH 1/7] KVM: Add a route layer to convert MSI message to GSI Date: Fri, 9 Jan 2009 09:51:25 +0800 Message-ID: <200901090951.26318.sheng@linux.intel.com> References: <1231411535-2461-1-git-send-email-sheng@linux.intel.com> <1231411535-2461-2-git-send-email-sheng@linux.intel.com> <20090108142022.GA5178@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Avi Kivity , kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mga09.intel.com ([134.134.136.24]:62562 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbZAIBv3 (ORCPT ); Thu, 8 Jan 2009 20:51:29 -0500 In-Reply-To: <20090108142022.GA5178@amt.cnet> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Thursday 08 January 2009 22:20:22 Marcelo Tosatti wrote: > On Thu, Jan 08, 2009 at 06:45:29PM +0800, Sheng Yang wrote: > > * ioctls for VM fds > > @@ -433,6 +436,8 @@ struct kvm_trace_rec { > > #define KVM_ASSIGN_IRQ _IOR(KVMIO, 0x70, \ > > struct kvm_assigned_irq) > > #define KVM_REINJECT_CONTROL _IO(KVMIO, 0x71) > > +#define KVM_REQUEST_GSI_ROUTE _IOWR(KVMIO, 0x72, void *) > > +#define KVM_FREE_GSI_ROUTE _IOR(KVMIO, 0x73, void *) > > Oh this slipped: should be struct kvm_gsi_route_guest. Oh, yeah, forgot to change it back(I original purpose a array here...) > > > /* > > * ioctls for vcpu fds > > @@ -553,4 +558,25 @@ struct kvm_assigned_irq { > > #define KVM_DEV_IRQ_ASSIGN_MSI_ACTION KVM_DEV_IRQ_ASSIGN_ENABLE_MSI > > #define KVM_DEV_IRQ_ASSIGN_ENABLE_MSI (1 << 0) > > > > +struct kvm_gsi_route_guest { > > + __u32 entries_nr; > > + struct kvm_gsi_route_entry_guest *entries; > > +}; > > And you can use a zero sized array here. OK. > > Sorry :( Oh, that's not necessary. :) -- regards Yang, Sheng