From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: kvm: make --mem-path memory allocation depend on mmu notifiers
Date: Tue, 13 Jan 2009 18:36:17 -0200
Message-ID: <20090113203617.GA8671@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>
To: kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:41976 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753498AbZAMUg0 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 13 Jan 2009 15:36:26 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0DKaQ8S030550
	for <kvm@vger.kernel.org>; Tue, 13 Jan 2009 15:36:26 -0500
Content-Disposition: inline
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


Without mmu notifiers usage of hugepages to back guest memory can cause
memory corruption.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>


diff --git a/qemu/vl.c b/qemu/vl.c
index d0660ab..49cf066 100644
--- a/qemu/vl.c
+++ b/qemu/vl.c
@@ -4664,6 +4664,11 @@ void *alloc_mem_area(size_t memory, unsigned long *len, const char *path)
     void *area;
     int fd;
 
+    if (!kvm_has_sync_mmu()) {
+        fprintf(stderr, "host lacks mmu notifiers, disabling --mem-path\n");
+        return NULL;
+    }
+
     if (asprintf(&filename, "%s/kvm.XXXXXX", path) == -1)
 	return NULL;