public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Mark McLoughlin <markmc@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Alexander Graf <agraf@suse.de>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: virtio breakage with 2.6.25 guest kernel
Date: Thu, 15 Jan 2009 12:47:53 +1030	[thread overview]
Message-ID: <200901151247.53979.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1231924978.4944.76.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]

On Wednesday 14 January 2009 19:52:58 Mark McLoughlin wrote:
> On Tue, 2009-01-13 at 22:05 +0100, Alexander Graf wrote:
> 
> > On 13.01.2009, at 21:14, Anthony Liguori <anthony@codemonkey.ws> wrote:
> > 
> > > Alexander Graf wrote:
> > >> Hi,
> > >>
> > >> while I don't fully understand the problem, here's what I  
> > >> experience so far:
> > >>
> > >> When using an openSUSE 11.0 kernel (2.6.25) in the guest, virtio on  
> > >> tap
> > >> breaks with current KVM git, while it used to work before (haven't
> > >> bisected, definitely worked in kvm-78, but is probably due to  
> > >> Anthony's
> > >> rewrite). It shows the following message (comes from qemu):
> > >>
> > >
> > > There were a couple of old-guest-breaking regressions.  I think  
> > > we've fixed all of them but there could be more.  Are you using the  
> > > latest kvm-userspace?
> 
> See:
> 
>   http://lists.gnu.org/archive/html/qemu-devel/2009-01/msg00574.html
> 
> > This one is definitely due to the broken guest kernel. I applied the  
> > patch mark mentioned to ours and things started working.
> > 
> > So the only way I can think of to 'fix' it is by detecting broken  
> > guests. We could supply a host mask of 0xffffffff and see if tge guest  
> > feature mask is tge same. If so, feature masking is probably broken.
> 
> Nice idea, but no way of making the guest through feature detection
> negotiation, I don't think.

Just add a feature "VIRTIO_F_LIES_ABOUT_FEATURES"?  No guest should ever set this.

But I'm not sure it's worth the pain...
Rusty.

[-- Attachment #2: Type: text/html, Size: 7972 bytes --]

      reply	other threads:[~2009-01-15  2:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <496C9813.7000609@suse.de>
2009-01-13 14:00 ` [Qemu-devel] virtio breakage with 2.6.25 guest kernel Avi Kivity
     [not found] ` <496CF614.5000405@codemonkey.ws>
     [not found]   ` <2D739E97-509B-4523-B04B-B18364C152EB@suse.de>
2009-01-14  9:22     ` Mark McLoughlin
2009-01-15  2:17       ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901151247.53979.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=agraf@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=markmc@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox