Re: [PATCH 0/7] qemu:virtio-net: Add MAC and VLAN filtering

Mark McLoughlin
2009-01-19T09:45:50Z

On Fri, 2009-01-16 at 14:09 -0700, Alex Williamson wrote:
> This series adds the ability for the guest to set the virtio-net device
> MAC address, a new control virtqueue for setting configuration data from
> the guest, and new interfaces making use of the control virtqueue for
> setting RX mode options, MAC filter table entries, and VLAN filter bits.
> The end result is that the virtio-net device has more of the features of
> a realy hardware NIC and can be configured to drop packets the guest
> isn't interested in seeing.
>
> This version incorporates the review comments from Mark McLoughlin,
> particularly including much better commit logs, factoring control
> commands into separate functions, and making a local ETH_ALEN define.
> Also new in this version is the addition of VLAN filtering. Please
> comment and/or apply. Thanks,
>
> Alex
>
> Note - This series depends on the previous patch sent to correct
> save and load of the virtio-net state.

I think it makes sense to wait for the linux side to be accepted first.
It's there the virtio guest ABI is defined, really. Apart from that, the
whole series looks good to me:

Acked-by: Mark McLoughlin <markmc@redhat.com>

Cheers,
Mark.