From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH] KVM: Avoid using CONFIG_ in userspace visible headers Date: Mon, 19 Jan 2009 14:22:14 +0100 Message-ID: <20090119132214.GA20722@elte.hu> References: <1232370050-7434-1-git-send-email-avi@redhat.com> <20090119130927.GC6876@elte.hu> <49747C44.1030901@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sam Ravnborg , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, "H. Peter Anvin" , Thomas Gleixner To: Avi Kivity Return-path: Content-Disposition: inline In-Reply-To: <49747C44.1030901@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org * Avi Kivity wrote: > Ingo Molnar wrote: >> * Avi Kivity wrote: >> >> >>> Kconfig symbols are not available in userspace, and are not stripped by >>> headers-install. Avoid their use by adding #defines in to >>> suit each architecture. >>> >>> >> looks good - you will push this via the KVM tree, right? >> > > Yes. Thanks for the review. btw., would be nice to somehow untangle consciously-exported interface definitions from kernel side bits, and standardize these feature/capability flags like __KVM_HAVE_IOAPIC, etc. Right now we have this body of 75,000 lines of code spread out in 600+ header files that are so-called 'exported' to user-space, but 95% of that interface definition code is never being relied on by any user-space bit! They are exported due to cargo-cult mentality or due to dependencies. It would be far better to have an explicit place for such bits, include/syscall-ABI/ or so - and not export _any_ other kernel headers. But that's a much larger project. Ingo