From: Sam Ravnborg <sam@ravnborg.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Avi Kivity <avi@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] KVM: Avoid using CONFIG_ in userspace visible headers
Date: Mon, 19 Jan 2009 17:29:47 +0100 [thread overview]
Message-ID: <20090119162947.GA10378@uranus.ravnborg.org> (raw)
In-Reply-To: <20090119132214.GA20722@elte.hu>
>
> btw., would be nice to somehow untangle consciously-exported interface
> definitions from kernel side bits, and standardize these
> feature/capability flags like __KVM_HAVE_IOAPIC, etc.
>
> Right now we have this body of 75,000 lines of code spread out in 600+
> header files that are so-called 'exported' to user-space, but 95% of that
> interface definition code is never being relied on by any user-space bit!
> They are exported due to cargo-cult mentality or due to dependencies.
With the exported headers we at least have a clear definition
what part of the headers are actually exported.
So what we have now is a much better base to cut off from.
And there is plenty of room for improvements but it requires
someone with understanding of the kernel side and the user side to do
this.
I for once find it hard to judge what is really used by user space and
not. Diving into glibc does not help as userspace is much more than
glibc although glibc is an important 'customer' here.
Sam
next prev parent reply other threads:[~2009-01-19 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 13:00 [PATCH] KVM: Avoid using CONFIG_ in userspace visible headers Avi Kivity
2009-01-19 13:09 ` Ingo Molnar
2009-01-19 13:12 ` Avi Kivity
2009-01-19 13:22 ` Ingo Molnar
2009-01-19 13:31 ` Avi Kivity
2009-01-19 16:29 ` Sam Ravnborg [this message]
2009-01-19 16:35 ` Avi Kivity
2009-01-19 16:32 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090119162947.GA10378@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox