From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] report IRQ injection status to userspace.
Date: Tue, 20 Jan 2009 14:53:40 -0200
Message-ID: <20090120165340.GA28270@amt.cnet>
References: <20090120134653.GD27675@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:35285 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757706AbZATQyG (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 20 Jan 2009 11:54:06 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0KGs2JQ012573
	for <kvm@vger.kernel.org>; Tue, 20 Jan 2009 11:54:02 -0500
Content-Disposition: inline
In-Reply-To: <20090120134653.GD27675@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Gleb,

Don't you want IRQ ack notification instead to control reinjection?

Because I think you'll always see a successful injection if using PIC.

On Tue, Jan 20, 2009 at 03:46:53PM +0200, Gleb Natapov wrote:

> diff --git a/include/linux/kvm.h b/include/linux/kvm.h
> index 869462c..b2c6b93 100644
> --- a/include/linux/kvm.h
> +++ b/include/linux/kvm.h
> @@ -48,7 +48,10 @@ struct kvm_irq_level {
>  	 * For IA-64 (APIC model) IOAPIC0: irq 0-23; IOAPIC1: irq 24-47..
>  	 * For X86 (standard AT mode) PIC0/1: irq 0-15. IOAPIC0: 0-23..
>  	 */
> -	__u32 irq;
> +	union {
> +		__u32 irq;
> +		__s32 status;
> +	};
>  	__u32 level;
>  };

And won't this break older userspace?