From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] report IRQ injection status to userspace. Date: Wed, 21 Jan 2009 12:03:44 +0200 Message-ID: <20090121100344.GG27675@redhat.com> References: <20090120134653.GD27675@redhat.com> <20090120165340.GA28270@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Avi Kivity To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:49004 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbZAUKFd (ORCPT ); Wed, 21 Jan 2009 05:05:33 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0LA5WSC016511 for ; Wed, 21 Jan 2009 05:05:32 -0500 Content-Disposition: inline In-Reply-To: <20090120165340.GA28270@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jan 20, 2009 at 02:53:40PM -0200, Marcelo Tosatti wrote: > Because I think you'll always see a successful injection if using PIC. > I've looked at the code one more time and I think that return value is correct for edge triggered interrupt. Injection of level triggered interrupt will always succeed as you say but this is more or less intentional. Device that uses level triggered interrupt can track interrupt status by itself since it controls IRQ line level. But I'll fix PIC code to return proper status anyway. -- Gleb.