Re: [PATCH 1/3] kvm-s390: Fix printk on SIGP set arch

Heiko Carstens
2009-01-22T11:18:19Z

On Thu, 22 Jan 2009 10:27:38 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> KVM on s390 does not support the ESA/390 architecture. We refuse to
> change the architecture mode and print a warning. While testing a
> crashme for kvm, I spotted two problems with the printk:
>
> o A malicious can flood host dmesg
> o There was no newline at the end of the printk
>
> This patch fixes both problems.
[...]
> - printk(KERN_WARNING "kvm: request to switch to ESA/390 mode"
> - " not supported");
> + if (printk_ratelimit())
> + printk(KERN_WARNING "kvm: request to switch to ESA/390"
> + " mode not supported\n");

Why don't you just remove the printk? IMHO it's rather pointless.