Re: [PATCH 1/3 v2] kvm-s390: Fix printk on SIGP set arch

Avi Kivity
2009-01-22T14:25:11Z

Christian Borntraeger wrote:
> Am Thursday 22 January 2009 12:58:57 schrieb Avi Kivity:
>
>> Right, either inject an exception to the guest (if appropriate for the
>> arch), or return -ESOMETHING from ioctl(KVM_RUN).
>>
>
> Ok. What about:
>
> [PATCH] kvm-s390: fix printk on SIGP set arch
>
> From: Christian Borntraeger <borntraeger@de.ibm.com>
> Reported-by: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> KVM on s390 does not support the ESA/390 architecture. We refuse to
> change the architecture mode and print a warning. This patch removes
> the printk for several reasons:
>
> o A malicious can flood host dmesg
> o The old message had no newline
> o there is no connection between the message and the failing guest
>
> This patch simply removes the printk. We already set the condition
> code to 3 - the guest knows that something went wrong.
>

Applied (with the other patches), thanks. Please include a printk()
patch in every s390 patchset so people can participate in the review and
discussion.

--
error compiling committee.c: too many arguments to function