Re: [PATCH 1/3] kvm-s390: Fix printk on SIGP set arch

Avi Kivity
2009-01-22T11:59:04Z

Heiko Carstens wrote:
> On Thu, 22 Jan 2009 12:26:11 +0100
> Carsten Otte <cotte@de.ibm.com> wrote:
>
>
>> Am Thu, 22 Jan 2009 12:17:07 +0100
>> schrieb heicars2@linux.vnet.ibm.com:
>>
>>> Why don't you just remove the printk? IMHO it's rather pointless.
>>>
>> It is'nt: It infoms the user why his guest is going to crash
>> even though it has performed an operation that is perfectly
>> legal according to the spec.
>>
>
> If you have hundreds of guests running, how do you get the connection
> from this message to a specific user process?
>
> Informing a user process that it did something that isn't allowed or
> supported is usually done by returning an appropriate return code.
>

Right, either inject an exception to the guest (if appropriate for the
arch), or return -ESOMETHING from ioctl(KVM_RUN).

--
error compiling committee.c: too many arguments to function