From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Carsten Otte <cotte@de.ibm.com>
Cc: heicars2@linux.vnet.ibm.com, borntrae@linux.vnet.ibm.com,
Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org,
Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>,
Olaf Schnapper <os@de.ibm.com>
Subject: Re: [PATCH 1/3] kvm-s390: Fix printk on SIGP set arch
Date: Thu, 22 Jan 2009 12:44:36 +0100 [thread overview]
Message-ID: <20090122124436.7fe42e85@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20090122122611.28ceddd2@cotte.boeblingen.de.ibm.com>
On Thu, 22 Jan 2009 12:26:11 +0100
Carsten Otte <cotte@de.ibm.com> wrote:
> Am Thu, 22 Jan 2009 12:17:07 +0100
> schrieb heicars2@linux.vnet.ibm.com:
> > Why don't you just remove the printk? IMHO it's rather pointless.
> It is'nt: It infoms the user why his guest is going to crash
> even though it has performed an operation that is perfectly
> legal according to the spec.
If you have hundreds of guests running, how do you get the connection
from this message to a specific user process?
Informing a user process that it did something that isn't allowed or
supported is usually done by returning an appropriate return code.
Also, if you have one "evil" process and hit the prink_limit the
messages for all other processes will likely be lost anyway.
next prev parent reply other threads:[~2009-01-22 11:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 9:26 [PATCH 0/3] kvm-s390: three kernel fixes Christian Borntraeger
2009-01-22 9:27 ` [PATCH 1/3] kvm-s390: Fix printk on SIGP set arch Christian Borntraeger
2009-01-22 11:17 ` Heiko Carstens
2009-01-22 11:26 ` Carsten Otte
2009-01-22 11:44 ` Heiko Carstens [this message]
2009-01-22 11:58 ` Avi Kivity
2009-01-22 12:14 ` Carsten Otte
2009-01-22 13:20 ` [PATCH 1/3 v2] " Christian Borntraeger
2009-01-22 14:23 ` Avi Kivity
2009-01-22 11:41 ` [PATCH 1/3] " Amit Shah
2009-01-22 9:28 ` [PATCH 2/3] kvm-s390: Fix problem state check for b2 intercepts Christian Borntraeger
2009-01-22 9:29 ` [PATCH 3/3] kvm-s390: Fix SIGP set prefix ioctl Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090122124436.7fe42e85@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=avi@redhat.com \
--cc=borntrae@linux.vnet.ibm.com \
--cc=cotte@de.ibm.com \
--cc=ehrhardt@linux.vnet.ibm.com \
--cc=heicars2@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=os@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox